-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(autoware_detected_object_feature_remover): add unit testing for the node #8735
test(autoware_detected_object_feature_remover): add unit testing for the node #8735
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
5a5ab07
to
62aeaf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested within my local environment.
@tkimura4 Could you approve this? Nobody except you has right access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YoshiRi
Can you add a maintainer on the Perception team?
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
62aeaf2
to
9685f72
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8735 +/- ##
==========================================
- Coverage 28.48% 28.42% -0.07%
==========================================
Files 1314 1314
Lines 98292 98304 +12
Branches 39995 39974 -21
==========================================
- Hits 27999 27943 -56
- Misses 70228 70296 +68
Partials 65 65
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Add unit testing for
DetectedObjectFeatureRemover
.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.