Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_detected_object_feature_remover): add unit testing for the node #8735

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Sep 3, 2024

Description

Add unit testing for DetectedObjectFeatureRemover.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ktro2828 ktro2828 force-pushed the test/autoware_detected_object_feature_remover branch from 5a5ab07 to 62aeaf2 Compare September 3, 2024 11:16
@ktro2828 ktro2828 marked this pull request as ready for review September 3, 2024 11:16
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested within my local environment.

@YoshiRi
Copy link
Contributor

YoshiRi commented Sep 26, 2024

@tkimura4 Could you approve this? Nobody except you has right access.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi
Can you add a maintainer on the Perception team?

@YoshiRi
Copy link
Contributor

YoshiRi commented Sep 26, 2024

@tkimura4
I created PR to add uetake-san and me to maintain this package. Please check it.
#8962

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the test/autoware_detected_object_feature_remover branch from 62aeaf2 to 9685f72 Compare September 26, 2024 06:06
@ktro2828 ktro2828 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2024
@ktro2828 ktro2828 enabled auto-merge (squash) September 26, 2024 06:09
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.42%. Comparing base (9fd0dae) to head (9685f72).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8735      +/-   ##
==========================================
- Coverage   28.48%   28.42%   -0.07%     
==========================================
  Files        1314     1314              
  Lines       98292    98304      +12     
  Branches    39995    39974      -21     
==========================================
- Hits        27999    27943      -56     
- Misses      70228    70296      +68     
  Partials       65       65              
Flag Coverage Δ *Carryforward flag
differential 2.94% <ø> (?)
total 28.44% <ø> (-0.04%) ⬇️ Carriedforward from 9fd0dae

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktro2828 ktro2828 merged commit 0e25a8b into autowarefoundation:main Sep 26, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Development

Successfully merging this pull request may close these issues.

3 participants