Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_state_rviz_plugin): fix unmatchedSuppression #8658

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unmatchedSuppression warnings.

Added a warning suppression comment in a previous PR, but corrected it because it had added an extra one as well.

common/tier4_state_rviz_plugin/src/custom_container.cpp:44:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QSize CustomContainer::minimumSizeHint() const
^
common/tier4_state_rviz_plugin/src/custom_icon_label.cpp:54:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QSize CustomIconLabel::minimumSizeHint() const
^
common/tier4_state_rviz_plugin/src/custom_icon_label.cpp:60:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomIconLabel::paintEvent(QPaintEvent *)
^
common/tier4_state_rviz_plugin/src/custom_label.cpp:50:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QSize CustomLabel::minimumSizeHint() const
^
common/tier4_state_rviz_plugin/src/custom_label.cpp:56:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomLabel::paintEvent(QPaintEvent *)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button.cpp:59:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
QSize CustomSegmentedButton::minimumSizeHint() const
^
common/tier4_state_rviz_plugin/src/custom_segmented_button.cpp:65:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButton::paintEvent(QPaintEvent *)
^
common/tier4_state_rviz_plugin/src/custom_segmented_button_item.cpp:80:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSegmentedButtonItem::paintEvent(QPaintEvent *)
^
common/tier4_state_rviz_plugin/src/custom_slider.cpp:23:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomSlider::paintEvent(QPaintEvent *)
^
common/tier4_state_rviz_plugin/src/custom_toggle_switch.cpp:34:0: information: Unmatched suppression: unusedFunction [unmatchedSuppression]
void CustomToggleSwitch::paintEvent(QPaintEvent *)

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 28, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2024
@kobayu858 kobayu858 requested a review from veqcc August 28, 2024 10:26
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.11%. Comparing base (bda8706) to head (1b4acf0).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8658      +/-   ##
==========================================
+ Coverage   24.10%   24.11%   +0.01%     
==========================================
  Files        1399     1400       +1     
  Lines      102337   102334       -3     
  Branches    38870    38881      +11     
==========================================
+ Hits        24668    24679      +11     
- Misses      75141    75184      +43     
+ Partials     2528     2471      -57     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 24.11% <ø> (+0.01%) ⬆️ Carriedforward from 441bfcf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit 17ad425 into autowarefoundation:main Aug 30, 2024
41 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…ation#8658)

fix:unmatchedSuppression

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…ation#8658)

fix:unmatchedSuppression

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants