Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_adapi_rviz_plugin, tier4_state_rviz_plugin): set timestamp to velocity_limit msg from rviz panels #8548

Merged

Conversation

Autumn60
Copy link
Contributor

Description

 Fixed tier4_planning::msgs::msg::VelocityLimit type topic from the Rviz plugin was not given a timestamp.

Related links

None.

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Autumn60 Autumn60 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.92%. Comparing base (b501569) to head (db81f89).
Report is 3 commits behind head on main.

Files Patch % Lines
common/tier4_adapi_rviz_plugin/src/state_panel.cpp 0.00% 1 Missing ⚠️
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8548      +/-   ##
==========================================
+ Coverage   23.90%   23.92%   +0.01%     
==========================================
  Files        1382     1384       +2     
  Lines      101975   101991      +16     
  Branches    38831    38832       +1     
==========================================
+ Hits        24381    24397      +16     
+ Misses      75131    75105      -26     
- Partials     2463     2489      +26     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 23.92% <ø> (+0.01%) ⬆️ Carriedforward from 7c0bbab

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Autumn60 Autumn60 merged commit 098da32 into autowarefoundation:main Aug 21, 2024
29 of 30 checks passed
@Autumn60 Autumn60 deleted the feat/common/velocity_limit_stamp branch August 21, 2024 07:05
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
… to velocity_limit msg from rviz panels (autowarefoundation#8548)

set timestamp to velocity_limit msg

Signed-off-by: Autumn60 <harada.akiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants