fix(static_obstacle_avoidance): target object sorting #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
go-sakayori
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
go-sakayori
changed the title
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
go-sakayori
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8545 +/- ##
=======================================
Coverage 23.88% 23.88%
=======================================
Files 1381 1382 +1
Lines 101993 102008 +15
Branches 38852 38853 +1
=======================================
+ Hits 24357 24361 +4
- Misses 75207 75219 +12
+ Partials 2429 2428 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…tion#8545) * fix compensateLostTargetObjects function Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * remove empty case Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> --------- Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
go-sakayori
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 28, 2024
…tion#8545) * fix compensateLostTargetObjects function Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * remove empty case Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> --------- Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
shmpwk
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 29, 2024
…avoidance fix(static_obstacle_avoidance): cherry-pick AWF autowarefoundation#8545, autowarefoundation#8551
go-sakayori
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 3, 2024
…tion#8545) * fix compensateLostTargetObjects function Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * remove empty case Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> --------- Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
kotaro-hihara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 3, 2024
…e_avoidance fix(static_obstacle_avoidance): cherry-pick autowarefoundation#8545, autowarefoundation#8551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The targets object was not added to the member variable
registered_objects_, so the envelope polygon for the target object was updated with a single shot polygon. This PR will fix the above problem by adding the target objects intoregistered_objects_appropriately.Related links
None
How was this PR tested?
TIER IV internal test
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.