Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ground_segmentation): missing default parameters ERROR #8538

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Aug 20, 2024

Description

  • To fix missing parameters error:
ubuntu22:~/autoware$ ros2 launch autoware_ground_segmentation scan_ground_filter.launch.py 
[INFO] [launch]: All log files can be found below /home/autoware/.ros/log/2024-08-20-20-50-28-074447-npc2201009-ubuntu22-95182
[INFO] [launch]: Default logging verbosity is set to INFO
...
rclcpp_components::NodeFactoryTemplate<autoware::ground_segmentation::ScanGroundFilterComponent>
[component_container-1] [ERROR] [1724154628.708955855] [scan_ground_filter_container]: Component constructor threw an exception: Statically typed parameter 'low_priority_region_x' must be initialized.
[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'scan_ground_filter' of type 'autoware::ground_segmentation::ScanGroundFilterComponent' in container '/scan_ground_filter_container': Component constructor threw an exception: Statically typed parameter 'low_priority_region_x' must be initialized.

Related links

Parent Issue:

  • Link

How was this PR tested?

  • Confirmed ros2 launch autoware_ground_segmentation scan_ground_filter.launch.py worked
ubuntu22:~/autoware$ ros2 launch autoware_ground_segmentation scan_ground_filter.launch.py 
[INFO] [launch]: All log files can be found below /home/autoware/.ros/log/2024-08-20-20-56-06-469739-npc2201009-ubuntu22-96487
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [component_container-1]: process started with pid [96498]
[component_container-1] [INFO] [1724154966.828702283] [scan_ground_filter_container]: Load Library: /home/autoware/autoware/install/autoware_ground_segmentation/lib/libautoware_ground_segmentation.so
[component_container-1] [INFO] [1724154966.880554280] [scan_ground_filter_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::ground_segmentation::RANSACGroundFilterComponent>
[component_container-1] [INFO] [1724154966.880624768] [scan_ground_filter_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::ground_segmentation::RayGroundFilterComponent>
[component_container-1] [INFO] [1724154966.880629587] [scan_ground_filter_container]: Found class: rclcpp_components::NodeFactoryTemplate<autoware::ground_segmentation::ScanGroundFilterComponent>
[component_container-1] [INFO] [1724154966.880633680] [scan_ground_filter_container]: Instantiate class: rclcpp_components::NodeFactoryTemplate<autoware::ground_segmentation::ScanGroundFilterComponent>
[INFO] [launch_ros.actions.load_composable_nodes]: Loaded node '/scan_ground_filter' in container '/scan_ground_filter_container'

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 20, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@badai-nguyen badai-nguyen added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 20, 2024
@badai-nguyen badai-nguyen marked this pull request as ready for review August 20, 2024 12:07
@badai-nguyen badai-nguyen enabled auto-merge (squash) August 20, 2024 12:07
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.91%. Comparing base (7424c48) to head (4da99a3).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8538   +/-   ##
=======================================
  Coverage   23.91%   23.91%           
=======================================
  Files        1381     1381           
  Lines      101939   101878   -61     
  Branches    38822    38774   -48     
=======================================
- Hits        24376    24362   -14     
+ Misses      75119    75072   -47     
  Partials     2444     2444           
Flag Coverage Δ *Carryforward flag
differential 11.42% <ø> (?)
total 23.91% <ø> (+<0.01%) ⬆️ Carriedforward from 9a461b4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen merged commit 47113d7 into autowarefoundation:main Aug 20, 2024
41 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…oundation#8538)

fix(ground_segmentation): remove unused params

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants