Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interpolation): fix unusedFunction #8522

Merged

Conversation

Nagi70
Copy link
Contributor

@Nagi70 Nagi70 commented Aug 19, 2024

Description

This is a fix based on cppcheck unusedFunction warnings

common/interpolation/src/spline_interpolation_points_2d.cpp:74:0: style: The function 'slerp2dFromXY' is never used. [unusedFunction]
std::array<std::vector<double>, 3> slerp2dFromXY(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Nagi70 <n.yoshimura.060@ms.saitama-u.ac.jp>
@Nagi70 Nagi70 requested a review from veqcc August 19, 2024 03:36
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Nagi70 Nagi70 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.88%. Comparing base (9a461b4) to head (14be43f).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8522      +/-   ##
==========================================
- Coverage   23.90%   23.88%   -0.02%     
==========================================
  Files        1381     1384       +3     
  Lines      101923   101940      +17     
  Branches    38808    38816       +8     
==========================================
- Hits        24363    24351      -12     
- Misses      75116    75117       +1     
- Partials     2444     2472      +28     
Flag Coverage Δ *Carryforward flag
differential 23.41% <ø> (?)
total 23.89% <ø> (-0.01%) ⬇️ Carriedforward from bfcd161

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit fb14444 into autowarefoundation:main Aug 21, 2024
29 of 30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
fix: unusedFunction

Signed-off-by: Nagi70 <n.yoshimura.060@ms.saitama-u.ac.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants