Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_mission_planner): fix noConstructor #8505

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck noConstructor warnings.

planning/autoware_mission_planner/src/lanelet2_plugins/default_planner.hpp:44:1: style: The class 'DefaultPlanner' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor]
class DefaultPlanner : public mission_planner::PlannerPlugin
^

In is_graph_ready_(false), param_(), and node_(nullptr), initialization is done with reference to void DefaultPlanner::initialize_common. route_handler_() uses the class RouteHandler_() uses the default constructor of class RouteHandler_() for initialization.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 16, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 16, 2024
@kosuke55 kosuke55 enabled auto-merge (squash) August 16, 2024 08:16
@kosuke55 kosuke55 merged commit 6c5f9b1 into autowarefoundation:main Aug 16, 2024
37 of 39 checks passed
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.88%. Comparing base (3470824) to head (a9f9a9a).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8505      +/-   ##
==========================================
- Coverage   23.89%   23.88%   -0.02%     
==========================================
  Files        1380     1387       +7     
  Lines      101835   101903      +68     
  Branches    38773    38776       +3     
==========================================
+ Hits        24337    24338       +1     
- Misses      75041    75108      +67     
  Partials     2457     2457              
Flag Coverage Δ *Carryforward flag
differential 9.30% <100.00%> (?)
total 23.89% <ø> (ø) Carriedforward from 3470824

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 deleted the fix/cppcheck_noConstructor_pla-1 branch August 21, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants