perf(autoware_map_based_prediction): removed duplicate findNearest calculations #8490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculations Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8490 +/- ##
==========================================
+ Coverage 23.87% 23.89% +0.01%
==========================================
Files 1380 1382 +2
Lines 101838 101872 +34
Branches 38775 38791 +16
==========================================
+ Hits 24315 24341 +26
- Misses 75047 75099 +52
+ Partials 2476 2432 -44
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yhisaki
requested review from
ktro2828,
kyoichi-sugahara,
takayuki5168,
tkimura4 and
YoshiRi
as code owners
soblin
reviewed
Aug 15, 2024
perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp
Outdated
Show resolved
Hide resolved
…ion_node.cpp Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
soblin
approved these changes
Aug 15, 2024
perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp
Outdated
Show resolved
Hide resolved
YoshiRi
approved these changes
Aug 15, 2024
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Aug 16, 2024
…lculations (autowarefoundation#8490) Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
technolojin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 16, 2024
…lculations (autowarefoundation#8490) (#1470) Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> Co-authored-by: Yukinari Hisaki <42021302+yhisaki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains 2 changes.
Perfomance Improvement
How was this PR tested?
https://evaluation.tier4.jp/evaluation/reports/b4f0ddee-5301-5708-a968-41699f2d7c0b?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.