Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): update filtered objects only once #8489

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Aug 15, 2024

Description

calls to filterObjects are made during both before and after RTC approval.
At the same time, it is also called during stop point insertion.
As filtering objects consumes processing time, in time PR, the filterObject is done only once, and the result is assigned to a member variable in lane change module.

Related links

Parent Issue:

  • Link

How was this PR tested?

PSIM.
TIER IV internal link

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.88%. Comparing base (0649ede) to head (9578c0c).
Report is 6 commits behind head on main.

Files Patch % Lines
...are_behavior_path_lane_change_module/src/scene.cpp 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8489      +/-   ##
==========================================
+ Coverage   23.86%   23.88%   +0.01%     
==========================================
  Files        1380     1381       +1     
  Lines      101866   101896      +30     
  Branches    38792    38797       +5     
==========================================
+ Hits        24308    24335      +27     
- Misses      75047    75129      +82     
+ Partials     2511     2432      -79     
Flag Coverage Δ *Carryforward flag
differential 15.51% <42.85%> (?)
total 23.87% <ø> (+<0.01%) ⬆️ Carriedforward from a612530

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the update-filtered-objects-only-once branch from 601179b to 05c3e30 Compare August 15, 2024 08:33
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the update-filtered-objects-only-once branch from 05c3e30 to 9578c0c Compare August 16, 2024 02:38
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 77059a1 into autowarefoundation:main Aug 16, 2024
31 of 32 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the update-filtered-objects-only-once branch August 16, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants