-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_pointcloud_preprocessor): rework blockage diag parameters #8488
refactor(autoware_pointcloud_preprocessor): rework blockage diag parameters #8488
Conversation
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8488 +/- ##
==========================================
- Coverage 23.91% 23.86% -0.05%
==========================================
Files 1381 1383 +2
Lines 101939 101830 -109
Branches 38822 38801 -21
==========================================
- Hits 24376 24302 -74
+ Misses 75119 75046 -73
- Partials 2444 2482 +38
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
…meters (autowarefoundation#8488) * feat: rework blockage diag parameters Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix readme Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix schema description Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add boundary for schema Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Description
This PR includes the following changes
nodelet
tonode
.A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor blockage_diag_node.launch.xml
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.