Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_pointcloud_preprocessor): rework blockage diag parameters #8488

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Aug 15, 2024

Description

This PR includes the following changes

  1. Add parameter, launch file, and parameters schema for the node.
  2. Change the name nodelet to node.

A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.

Related links

Parent Issue:

  • Link

How was this PR tested?

ros2 launch autoware_pointcloud_preprocessor blockage_diag_node.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 15, 2024
@vividf vividf self-assigned this Aug 15, 2024
@vividf vividf added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.86%. Comparing base (7424c48) to head (9c7f615).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8488      +/-   ##
==========================================
- Coverage   23.91%   23.86%   -0.05%     
==========================================
  Files        1381     1383       +2     
  Lines      101939   101830     -109     
  Branches    38822    38801      -21     
==========================================
- Hits        24376    24302      -74     
+ Misses      75119    75046      -73     
- Partials     2444     2482      +38     
Flag Coverage Δ *Carryforward flag
differential 19.06% <ø> (?)
total 23.93% <ø> (+0.02%) ⬆️ Carriedforward from 6d88706

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf vividf enabled auto-merge (squash) August 20, 2024 07:53
@vividf vividf merged commit 8ba6168 into autowarefoundation:main Aug 20, 2024
29 of 30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…meters (autowarefoundation#8488)

* feat: rework blockage diag parameters

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: fix readme

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: fix schema description

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* chore: add boundary for schema

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

---------

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants