perf(goal_planner): reduce unnecessary recursive lock guard

[kosuke55]

Description

Reduced computational cost just a little bit. Reduced unnecessary recursive locks.

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 23.85%. Comparing base (a612530) to head (2589c66).
Report is 5 commits behind head on main.

Files	Patch %	Lines
...r_path_goal_planner_module/goal_planner_module.hpp	0.00%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8465      +/-   ##
==========================================
- Coverage   23.89%   23.85%   -0.05%     
==========================================
  Files        1381     1384       +3     
  Lines      101868   101925      +57     
  Branches    38799    38798       -1     
==========================================
- Hits        24344    24314      -30     
- Misses      75095    75180      +85     
- Partials     2429     2431       +2     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	23.87% <ø> (-0.03%)	⬇️	Carriedforward from a612530

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[soblin]

Can you declare set_xxx_no_lock as private ?

[kosuke55]

Can you declare set_xxx_no_lock as private ?

fixed in 304915f