fix(autoware_pointcloud_preprocessor): fix variableScope #8447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
kobayu858
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
vividf,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kobayu858
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8447 +/- ##
==========================================
+ Coverage 23.85% 23.86% +0.01%
==========================================
Files 1379 1381 +2
Lines 101614 101615 +1
Branches 38644 38639 -5
==========================================
+ Hits 24238 24250 +12
+ Misses 74918 74902 -16
- Partials 2458 2463 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Shin-kyoto
requested changes
Aug 13, 2024
sensing/autoware_pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Shin-kyoto
approved these changes
Aug 13, 2024
|
@vividf |
vividf
reviewed
Aug 14, 2024
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…ndation#8447) * fix:variableScope Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> * refactor:use const Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> --------- Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix based on cppcheck variableScope warnings
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.