Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_planner_common): fix variableScope #8443

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck variableScope warnings

planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/utils.cpp:286:10: style: The scope of the variable 'min_dist' can be reduced. [variableScope]
  double min_dist = std::numeric_limits<double>::max();
         ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.87%. Comparing base (7382d66) to head (2f36569).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8443      +/-   ##
==========================================
+ Coverage   23.85%   23.87%   +0.01%     
==========================================
  Files        1379     1385       +6     
  Lines      101614   101647      +33     
  Branches    38634    38654      +20     
==========================================
+ Hits        24244    24268      +24     
- Misses      74861    74929      +68     
+ Partials     2509     2450      -59     
Flag Coverage Δ *Carryforward flag
differential 15.09% <ø> (?)
total 23.90% <ø> (+0.04%) ⬆️ Carriedforward from 9876c76

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit 4d1c7fc into autowarefoundation:main Aug 20, 2024
38 of 39 checks passed
@kobayu858 kobayu858 deleted the fix/cppcheck_variableScope_pla-5 branch August 21, 2024 06:14
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…refoundation#8443)

fix:variableScope

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants