Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(out_of_lane): use rtree to get stop lines and trajectory lanelets #8439

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

Improve performance of the out_of_lane module by using rtree for efficient spatial queries.

Related links

How was this PR tested?

Psim and rosbag replay.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 26.19048% with 31 lines in your changes missing coverage. Please review.

Project coverage is 23.86%. Comparing base (7b1fc8c) to head (e69deb6).
Report is 3 commits behind head on main.

Files Patch % Lines
...ut_of_lane_module/src/filter_predicted_objects.cpp 0.00% 17 Missing ⚠️
...city_out_of_lane_module/src/out_of_lane_module.cpp 50.00% 10 Missing ⚠️
...city_out_of_lane_module/src/lanelets_selection.cpp 25.00% 2 Missing and 1 partial ⚠️
...e_motion_velocity_out_of_lane_module/src/types.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8439      +/-   ##
==========================================
+ Coverage   23.85%   23.86%   +0.01%     
==========================================
  Files        1379     1383       +4     
  Lines      101614   101654      +40     
  Branches    38645    38664      +19     
==========================================
+ Hits        24238    24261      +23     
- Misses      74881    74927      +46     
+ Partials     2495     2466      -29     
Flag Coverage Δ *Carryforward flag
differential 16.15% <26.19%> (?)
total 23.86% <ø> (+0.01%) ⬆️ Carriedforward from 4241a1d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maxime-clem and others added 5 commits August 13, 2024 16:28
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem merged commit 8a9efba into autowarefoundation:main Aug 13, 2024
28 of 30 checks passed
@maxime-clem maxime-clem deleted the perf/out_of_lane-rtree branch August 13, 2024 10:23
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Aug 14, 2024
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
autowarefoundation#8439)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: xtk8532704 <1041084556@qq.com>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Aug 16, 2024
#1461)

perf(out_of_lane): use rtree to get stop lines and trajectory lanelets (autowarefoundation#8439)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
mbharatheesha pushed a commit to nobleo/autoware.universe that referenced this pull request Aug 16, 2024
autowarefoundation#8439)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Mukunda Bharatheesha <mukunda.bharatheesha@nobleo.nl>
mbharatheesha pushed a commit to nobleo/autoware.universe that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants