perf(static_obstacle_avoidance): improve logic to reduce computational cost #8432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-ota
requested review from
rej55,
go-sakayori,
kyoichi-sugahara,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4,
zulfaqar-azmi-t4,
danielsanchezaran,
kosuke55,
soblin,
maxime-clem and
takayuki5168
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
go-sakayori
approved these changes
Aug 9, 2024
satoshi-ota
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8432 +/- ##
==========================================
- Coverage 23.89% 23.87% -0.02%
==========================================
Files 1379 1385 +6
Lines 101582 101625 +43
Branches 38638 38639 +1
==========================================
Hits 24268 24268
- Misses 74855 74898 +43
Partials 2459 2459
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
go-sakayori
approved these changes
Aug 13, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
perf/static-obstacle-avoidance
branch
from
7ba2c3d
to
fc3b7bc
Compare
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 13, 2024
…l cost (autowarefoundation#8432) * perf(safety_check): check within first Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove duplicated process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove heavy process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Naophis
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 13, 2024
perf(static_obstacle_avoidance): improve logic to reduce computational cost (autowarefoundation#8432)
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…l cost (autowarefoundation#8432) * perf(safety_check): check within first Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove duplicated process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove heavy process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…l cost (autowarefoundation#8432) * perf(safety_check): check within first Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove duplicated process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove heavy process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: xtk8532704 <1041084556@qq.com>
mbharatheesha
pushed a commit
to nobleo/autoware.universe
that referenced
this pull request
Aug 16, 2024
…l cost (autowarefoundation#8432) * perf(safety_check): check within first Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove duplicated process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove heavy process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Mukunda Bharatheesha <mukunda.bharatheesha@nobleo.nl>
mbharatheesha
pushed a commit
to nobleo/autoware.universe
that referenced
this pull request
Aug 16, 2024
…l cost (autowarefoundation#8432) * perf(safety_check): check within first Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove duplicated process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * perf(static_obstacle_avoidance): remove heavy process Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
272846b
Since the process of yaw deviation check is heavy, I fixed it in order to check object within/without target lane first.
d638d08
The
postProcess()function is automatically called in this line.7ba2c3d
Don't use heavy process
calcSignedArcLength().Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.