Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_tensorrt_yolox): fix variableScope #8430

Merged

Conversation

Nagi70
Copy link
Contributor

@Nagi70 Nagi70 commented Aug 9, 2024

Description

This is a fix based on cppcheck variableScope warnings

perception/autoware_tensorrt_yolox/src/tensorrt_yolox.cpp:775:24: style: The scope of the variable 'masks' can be reduced. [variableScope]
std::vectorcv::Mat masks;
^
perception/autoware_tensorrt_yolox/src/tensorrt_yolox.cpp:776:24: style: The scope of the variable 'color_masks' can be reduced. [variableScope]
std::vectorcv::Mat color_masks;
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Nagi70 <n.yoshimura.060@ms.saitama-u.ac.jp>
@Nagi70 Nagi70 requested a review from veqcc August 9, 2024 08:42
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.72%. Comparing base (7382d66) to head (dd5668e).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8430      +/-   ##
==========================================
- Coverage   23.85%   23.72%   -0.14%     
==========================================
  Files        1379     1379              
  Lines      101614   101409     -205     
  Branches    38634    38520     -114     
==========================================
- Hits        24244    24055     -189     
- Misses      74861    74965     +104     
+ Partials     2509     2389     -120     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.76% <ø> (-0.10%) ⬇️ Carriedforward from 8c5a24b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • I confirmed that this PR's content is good to merge.
  • I did NOT check this PR by running autoware.

@manato @dan-dnn
I think these changes are good to merge. How do you think about this PR?

Copy link
Contributor

@dan-dnn dan-dnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobayu858 kobayu858 merged commit 36f30d4 into autowarefoundation:main Aug 15, 2024
29 of 30 checks passed
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
)

fix: variableScope

Signed-off-by: Nagi70 <n.yoshimura.060@ms.saitama-u.ac.jp>
Co-authored-by: kobayu858 <129580202+kobayu858@users.noreply.github.com>
Signed-off-by: xtk8532704 <1041084556@qq.com>
@kobayu858 kobayu858 deleted the fix/cppcheck_variableScope_per-2 branch August 21, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants