fix(autoware_tracking_object_merger): add merge frame #8418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
kaancolak
requested review from
technolojin,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
YoshiRi
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8418 +/- ##
==========================================
- Coverage 23.74% 23.74% -0.01%
==========================================
Files 1378 1378
Lines 101350 101358 +8
Branches 38509 38508 -1
==========================================
Hits 24063 24063
- Misses 74816 74824 +8
Partials 2471 2471
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 13, 2024
…tion#8418) * fix(autoware_tracking_object_merger): add merge frame Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Aug 13, 2024
…tion#8418) * fix(autoware_tracking_object_merger): add merge frame Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…tion#8418) * fix(autoware_tracking_object_merger): add merge frame Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…tion#8418) * fix(autoware_tracking_object_merger): add merge frame Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, merging of different track objects is only possible in the "map" frame, it's hardcoded. However, some sensors like radar provide tracked objects as a local frame. I just added basic functionality that merges objects in the target frame.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.