Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_lane_departure_checker): not to show error message "trajectory deviation is too large" during manual driving #8404

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

T-Kimura-MM
Copy link
Contributor

Description

Update not to show error message "trajectory deviation is too large" during manual driving.
This message is necessary only during autonomous driving.

Related links

Parent Issue:

How was this PR tested?

It is tested using planning simulator.
You can see error message at rqt_runtime_monitor.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

… large" during manual driving

Signed-off-by: T-Kimura-MM <tkc1110bs@gmail.com>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@shmpwk shmpwk added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 23.67%. Comparing base (532c78c) to head (8584c12).
Report is 8 commits behind head on main.

Files Patch % Lines
...rture_checker_node/lane_departure_checker_node.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8404      +/-   ##
==========================================
- Coverage   23.86%   23.67%   -0.20%     
==========================================
  Files        1380     1385       +5     
  Lines      101679   101550     -129     
  Branches    38681    38557     -124     
==========================================
- Hits        24267    24037     -230     
- Misses      74939    75064     +125     
+ Partials     2473     2449      -24     
Flag Coverage Δ *Carryforward flag
differential 15.07% <0.00%> (?)
total 23.75% <ø> (-0.12%) ⬇️ Carriedforward from 45e134c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara
Copy link
Contributor

@T-Kimura-MM
LGTM for the change and it makes sense to me.
Could you briefly explain how did you test the change?

@T-Kimura-MM
Copy link
Contributor Author

@kyoichi-sugahara
Here is a way to conduct the test:

  1. Launch the planning simulator.
  2. Add a manual controller(https://github.com/autowarefoundation/autoware_tools/tree/main/common/tier4_control_rviz_plugin).
  3. Use the manual controller to intentionally shift the route.
  4. Confirm that no error message appears in this state.
  5. Switch to autonomous driving after deviating from the route.
  6. Confirm that a message appears when the route is deviated during autonomous driving.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for explanation about how to test! LGTM!

@shmpwk shmpwk enabled auto-merge (squash) August 14, 2024 05:04
@shmpwk shmpwk merged commit 73127b7 into autowarefoundation:main Aug 14, 2024
27 of 30 checks passed
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…ectory deviation is too large" during manual driving (autowarefoundation#8404)

* update: update not to show error message "trajectory deviation is too large" during manual driving

Signed-off-by: T-Kimura-MM <tkc1110bs@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: T-Kimura-MM <tkc1110bs@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants