fix(ring_outlier_filter): remove unnecessary resize to prevent zero points #8402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
vividf and
yukkysaito
as code owners
github-actions
bot
added
the
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kyoichi-sugahara
approved these changes
Aug 8, 2024
yukkysaito
approved these changes
Aug 8, 2024
|
Running smallest evaluator scenario https://evaluation.tier4.jp/evaluation/reports/cff46a5c-11eb-58e8-8ee8-f7c7c64e67cc?project_id=prd_jt |
miursh
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8402 +/- ##
=======================================
Coverage 23.73% 23.73%
=======================================
Files 1378 1380 +2
Lines 101354 101375 +21
Branches 38503 38515 +12
=======================================
+ Hits 24057 24066 +9
- Misses 74828 74894 +66
+ Partials 2469 2415 -54
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Aug 9, 2024
…oints (autowarefoundation#8402) fix: remove unnecessary resize Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Aug 13, 2024
…oints (autowarefoundation#8402) fix: remove unnecessary resize Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…oints (autowarefoundation#8402) fix: remove unnecessary resize Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi
added a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Aug 15, 2024
…oints (autowarefoundation#8402) fix: remove unnecessary resize Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…oints (autowarefoundation#8402) fix: remove unnecessary resize Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug that ring_outlier_filter outputs the
0,0,0points, due to unnecessary resizing.This bug results in extremely slow performance in the
occupancy_grid_based_outlier_filter.Related links
Parent Issue:
How was this PR tested?
Tested with logging simulator with actual rosbag.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.