Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system_monitor): fix unusedStructMember #8401

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unusedStructMember warnings.

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:63:11: style: struct member 'AtaPassThrough12::reserved0_' is never used. [unusedStructMember]
  uint8_t reserved0_ : 1;       //!< @brief Reserved
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:65:11: style: struct member 'AtaPassThrough12::multiple_count_' is never used. [unusedStructMember]
  uint8_t multiple_count_ : 3;  //!< @brief MULTIPLE_COUNT
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:69:11: style: struct member 'AtaPassThrough12::reserved1_' is never used. [unusedStructMember]
  uint8_t reserved1_ : 1;       //!< @brief Reserved
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:70:11: style: struct member 'AtaPassThrough12::ck_cond_' is never used. [unusedStructMember]
  uint8_t ck_cond_ : 1;         //!< @brief CK_COND
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:71:11: style: struct member 'AtaPassThrough12::off_line_' is never used. [unusedStructMember]
  uint8_t off_line_ : 2;        //!< @brief OFF_LINE
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:74:11: style: struct member 'AtaPassThrough12::lba_low_' is never used. [unusedStructMember]
  uint8_t lba_low_;             //!< @brief LBA_LOW (0:7)
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:77:11: style: struct member 'AtaPassThrough12::device_' is never used. [unusedStructMember]
  uint8_t device_;              //!< @brief DEVICE
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:79:11: style: struct member 'AtaPassThrough12::reserved2_' is never used. [unusedStructMember]
  uint8_t reserved2_;           //!< @brief Reserved
          ^

system/system_monitor/reader/hdd_reader/hdd_reader.cpp:80:11: style: struct member 'AtaPassThrough12::control_' is never used. [unusedStructMember]
  uint8_t control_;             //!< @brief CONTROL
          ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:58:12: style: struct member 'PackageThermalStatus::pkg_thermal_status_log_' is never used. [unusedStructMember]
  uint64_t pkg_thermal_status_log_ : 1;           //!< @brief 1 Pkg Thermal Status Log (R/W)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:59:12: style: struct member 'PackageThermalStatus::pkg_prochot_event_' is never used. [unusedStructMember]
  uint64_t pkg_prochot_event_ : 1;                //!< @brief 2 Pkg PROCHOT # event (RO)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:60:12: style: struct member 'PackageThermalStatus::pkg_prochot_log_' is never used. [unusedStructMember]
  uint64_t pkg_prochot_log_ : 1;                  //!< @brief 3 Pkg PROCHOT # log (R/WC0)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:61:12: style: struct member 'PackageThermalStatus::pkg_critical_temperature_status_' is never used. [unusedStructMember]
  uint64_t pkg_critical_temperature_status_ : 1;  //!< @brief 4 Pkg Critical Temperature Status (RO)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:63:5: style: struct member 'PackageThermalStatus::pkg_critical_temperature_status_log_' is never used. [unusedStructMember]
    pkg_critical_temperature_status_log_ : 1;     //!<   Status Log (R/WC0)
    ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:64:12: style: struct member 'PackageThermalStatus::pkg_thermal_threshold_1_status_' is never used. [unusedStructMember]
  uint64_t pkg_thermal_threshold_1_status_ : 1;   //!< @brief 6 Pkg Thermal Threshold #1 Status (RO)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:65:12: style: struct member 'PackageThermalStatus::pkg_thermal_threshold_1_log_' is never used. [unusedStructMember]
  uint64_t pkg_thermal_threshold_1_log_ : 1;      //!< @brief 7 Pkg Thermal Threshold #1 log (R/WC0)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:66:12: style: struct member 'PackageThermalStatus::pkg_thermal_threshold_2_status_' is never used. [unusedStructMember]
  uint64_t pkg_thermal_threshold_2_status_ : 1;   //!< @brief 8 Pkg Thermal Threshold #2 Status (RO)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:67:12: style: struct member 'PackageThermalStatus::pkg_thermal_threshold_2_log_' is never used. [unusedStructMember]
  uint64_t pkg_thermal_threshold_2_log_ : 1;      //!< @brief 9 Pkg Thermal Threshold #2 log (R/WC0)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:68:12: style: struct member 'PackageThermalStatus::pkg_power_limitation_status_' is never used. [unusedStructMember]
  uint64_t pkg_power_limitation_status_ : 1;      //!< @brief 10 Pkg Power Limitation Status (RO)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:69:12: style: struct member 'PackageThermalStatus::pkg_power_limitation_log_' is never used. [unusedStructMember]
  uint64_t pkg_power_limitation_log_ : 1;         //!< @brief 11 Pkg Power Limitation log (R/WC0)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:70:12: style: struct member 'PackageThermalStatus::reserved1_' is never used. [unusedStructMember]
  uint64_t reserved1_ : 4;                        //!< @brief 15:12 Reserved
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:71:12: style: struct member 'PackageThermalStatus::pkg_digital_readout_' is never used. [unusedStructMember]
  uint64_t pkg_digital_readout_ : 7;              //!< @brief 22:16 Pkg Digital Readout (RO)
           ^

system/system_monitor/reader/msr_reader/msr_reader.cpp:72:12: style: struct member 'PackageThermalStatus::reserved2_' is never used. [unusedStructMember]
  uint64_t reserved2_ : 41;                       //!< @brief 63:23 Reserved
           ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc August 8, 2024 05:45
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858
Copy link
Contributor Author

Since this is a structure that conforms to the specification, it has been comment suppressed rather than deleted.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 9, 2024
@ito-san ito-san enabled auto-merge (squash) August 9, 2024 02:12
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.76%. Comparing base (ba34878) to head (6b73b78).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8401      +/-   ##
==========================================
+ Coverage   23.72%   23.76%   +0.04%     
==========================================
  Files        1378     1379       +1     
  Lines      101365   101320      -45     
  Branches    38512    38502      -10     
==========================================
+ Hits        24051    24083      +32     
+ Misses      74859    74811      -48     
+ Partials     2455     2426      -29     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.77% <ø> (+0.04%) ⬆️ Carriedforward from 9af6322

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ito-san ito-san merged commit 7a4cb68 into autowarefoundation:main Aug 9, 2024
29 of 30 checks passed
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Aug 13, 2024
* fix:unusedStructMember

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedStructMember_sys-1 branch August 13, 2024 06:20
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
* fix:unusedStructMember

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
* fix:unusedStructMember

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants