-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner): fix cppcheck warnings of virtualCallInConstructor #8376
fix(behavior_velocity_planner): fix cppcheck warnings of virtualCallInConstructor #8376
Conversation
Signed-off-by: taisa1 <kento.osa@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8376 +/- ##
==========================================
+ Coverage 23.90% 29.21% +5.31%
==========================================
Files 1380 1615 +235
Lines 101750 119459 +17709
Branches 38714 51412 +12698
==========================================
+ Hits 24324 34902 +10578
- Misses 74920 75251 +331
- Partials 2506 9306 +6800
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nConstructor (autowarefoundation#8376) Co-authored-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Description
This is a fix based on cppcheck warning
virtualCallInConstructor
.Related links
Private Links:
How was this PR tested?
Only checked if build succeeded.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.