Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): ensure LC merging lane stop point is safe #8369

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Aug 6, 2024

Description

In case of LC merging lane pattern, the width of the lane at the stop point is not guaranteed to be sufficient for ego vehicle. If LC path is not approved and ego continues up to stop point, ego body can exceed lane boundaries which is unsafe.

Screenshot from 2024-08-05 17-14-23

Changes

  • added function isMergingLane in planner common utils to check for merging lane pattern
  • added function getDistanceFromLastFitWidthToEnd in planner common utils to compute distance from last center line point within width threshold to lane end
  • refactor function getSignedDistanceFromBoundary in planner common utils
  • in case of LC merging lane pattern, subtract computed distance from distance_to_terminal to ensure safe stopping point

How was this PR tested?

tested with psim.

Screenshot from 2024-08-07 10-49-30

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

When ego is approaching end of merging lane and LC path is not approved, ego should stop at safe point where ego body does not exceed lane boundaries

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
… lane end

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Copy link

github-actions bot commented Aug 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 23.78%. Comparing base (196b9fa) to head (aacea06).
Report is 5 commits behind head on main.

Files Patch % Lines
..._path_lane_change_module/src/utils/calculation.cpp 0.00% 21 Missing ⚠️
...e_behavior_path_planner_common/src/utils/utils.cpp 0.00% 15 Missing ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8369      +/-   ##
==========================================
- Coverage   23.87%   23.78%   -0.09%     
==========================================
  Files        1380     1389       +9     
  Lines      101867   101755     -112     
  Branches    38802    38622     -180     
==========================================
- Hits        24320    24205     -115     
+ Misses      75123    75093      -30     
- Partials     2424     2457      +33     
Flag Coverage Δ *Carryforward flag
differential 15.03% <0.00%> (?)
total 23.88% <ø> (+0.01%) ⬆️ Carriedforward from 91a0af3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
…oint-is-safe

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
…ne and lane polygon

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
mkquda and others added 3 commits August 16, 2024 09:55
…oint-is-safe

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this issue!

@mkquda mkquda merged commit 0c28bc9 into autowarefoundation:main Aug 16, 2024
28 of 30 checks passed
@mkquda mkquda deleted the RT1-7485-ensure-LC-merging-lane-stop-point-is-safe branch August 16, 2024 07:26
@xmfcx
Copy link
Contributor

xmfcx commented Aug 16, 2024

@xmfcx xmfcx mentioned this pull request Aug 16, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Aug 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants