Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_velocity_smoother): fix unreadVariable #8364

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unreadVariable warnings.

planning/autoware_velocity_smoother/src/trajectory_utils.cpp:541:11: style: Variable 'j' is assigned a value that is never used. [unreadVariable]
  double j{0.0};
          ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 5, 2024
@kobayu858 kobayu858 requested a review from veqcc August 5, 2024 11:10
Copy link

github-actions bot commented Aug 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.00%. Comparing base (022bd17) to head (debaa6d).
Report is 14 commits behind head on main.

Files Patch % Lines
...utoware_velocity_smoother/src/trajectory_utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8364      +/-   ##
==========================================
- Coverage   23.74%   23.00%   -0.75%     
==========================================
  Files        1379      391     -988     
  Lines      101356    29207   -72149     
  Branches    38523    10236   -28287     
==========================================
- Hits        24069     6719   -17350     
+ Misses      74872    21702   -53170     
+ Partials     2415      786    -1629     
Flag Coverage Δ
differential 23.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit 8c5a24b into autowarefoundation:main Aug 9, 2024
29 of 30 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Aug 9, 2024
…on#8364)

fix:unreadVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Aug 13, 2024
…on#8364)

fix:unreadVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…on#8364)

fix:unreadVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…on#8364)

fix:unreadVariable

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: xtk8532704 <1041084556@qq.com>
@kobayu858 kobayu858 deleted the fix/cppcheck_unreadVariable_pla-7 branch August 21, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants