Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): remove invalid small shift lines #8344

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 5, 2024

Description

 updateData: 1535.61 [ms]                                                                                                                                                                                                                                                                                                                                                                                                        
     ├── fillFundamentalData: 3.39 [ms]                                                                                                                                                                                                                                                                                                                                                                                          
     │   ├── extendBackwardLength: 0.15 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   ├── fillAvoidanceTargetObjects: 2.47 [ms]                                                                                                                                                                                                                                                                                                                                                                               
     │   │   ├── createObjectData: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   │   └── createObjectData: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   └── fillAvoidanceTargetData: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                  
     │       ├── calcDistanceToStopLine: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                               
     │       └── calcDistanceToStopLine: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                               
     ├── fillShiftLine: 1000.57 [ms]                                                                                                                                                                                                                                                                                                                                                                                             
     │   ├── isValidShiftLine: 0.31 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     │   │   └── addNewShiftLines: 0.05 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   ├── addNewShiftLines: 0.03 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     │   └── isSafePath: 0.04 [ms]                                                                                                                                                                                                                                                                                                                                                                                               
     ├── fillEgoStatus: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
     │   └── canYieldManeuver: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     ├── fillDebugData: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
     └── updateRTCData: 0.81 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
                                                                                                                                                                                                                                                                                                                                                                                                                                 
 planWaitingApproval: 0.85 [ms]                                                                                                                                                                                                                                                                                                                                                                                                  
     ├── plan: 0.79 [ms]                                                                                                                                                                                                                                                                                                                                                                                                         
     │   ├── insertPrepareVelocity: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                    
     │   ├── insertAvoidanceVelocity: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                  
     │   ├── insertStopPoint: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                          
     │   ├── insertReturnDeadLine: 0.02 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   ├── updateInfoMarker: 0.03 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     │   └── updateDebugMarker: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                        
     └── planCandidate: 0.05 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
                                                                                                                                                                                                                                                                                                                                                                                                                                 
 plan: 0.74 [ms]                                                                                                                                                                                                                                                                                                                                                                                                                 
     ├── insertPrepareVelocity: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                        
     ├── insertAvoidanceVelocity: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                      
     ├── insertStopPoint: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                              
     ├── insertReturnDeadLine: 0.02 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     ├── updateInfoMarker: 0.03 [ms]                                                                                                                                                                                                                                                                                                                                                                                             
     └── updateDebugMarker: 0.01 [ms] 
/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/processing_time/static_obstacle_avoidance                                                                                                                                                                                                                                                                                                       
 updateData: 1.14 [ms]                                                                                                                                                                                                                                                                                                                                                                                                           
     ├── fillFundamentalData: 0.93 [ms]                                                                                                                                                                                                                                                                                                                                                                                          
     │   ├── extendBackwardLength: 0.10 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   ├── fillAvoidanceTargetObjects: 0.48 [ms]                                                                                                                                                                                                                                                                                                                                                                               
     │   │   ├── createObjectData: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   │   └── createObjectData: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   └── fillAvoidanceTargetData: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                  
     ├── fillShiftLine: 0.05 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
     │   ├── isValidShiftLine: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     │   └── isSafePath: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                               
     ├── fillEgoStatus: 0.02 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
     │   └── canYieldManeuver: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     ├── fillDebugData: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
     └── updateRTCData: 0.09 [ms]                                                                                                                                                                                                                                                                                                                                                                                                
                                                                                                                                                                                                                                                                                                                                                                                                                                 
 plan: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                                                 
                                                                                                                                                                                                                                                                                                                                                                                                                                 
 planWaitingApproval: 3.32 [ms]                                                                                                                                                                                                                                                                                                                                                                                                  
     ├── plan: 3.26 [ms]                                                                                                                                                                                                                                                                                                                                                                                                         
     │   ├── addNewShiftLines: 0.04 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     │   ├── insertPrepareVelocity: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                    
     │   ├── insertAvoidanceVelocity: 0.01 [ms]                                                                                                                                                                                                                                                                                                                                                                                  
     │   ├── insertStopPoint: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                          
     │   ├── insertReturnDeadLine: 0.00 [ms]                                                                                                                                                                                                                                                                                                                                                                                     
     │   ├── updateInfoMarker: 0.03 [ms]                                                                                                                                                                                                                                                                                                                                                                                         
     │   └── updateDebugMarker: 2.40 [ms]                                                                                                                                                                                                                                                                                                                                                                                        
     └── planCandidate: 0.05 [ms]   

Related links

FAILED SCENARIO

webauto ci scenario run --project-id prd_jt --scenario-id 3298197a-fc47-4e9b-ae5d-445810d83127 --scenario-version-id 5 --scenario-parameters '__tier4_modifier_ego_speed=8.3333,__tier4_modifier_npc_interval=40'

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@go-sakayori go-sakayori added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.31%. Comparing base (ca32505) to head (5285330).
Report is 2 commits behind head on main.

Files Patch % Lines
...acle_avoidance_module/src/shift_line_generator.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8344      +/-   ##
==========================================
- Coverage   29.31%   29.31%   -0.01%     
==========================================
  Files        1609     1610       +1     
  Lines      119413   119430      +17     
  Branches    51480    51481       +1     
==========================================
+ Hits        35002    35006       +4     
- Misses      75111    75125      +14     
+ Partials     9300     9299       -1     
Flag Coverage Δ *Carryforward flag
differential 13.88% <0.00%> (?)
total 29.31% <ø> (+<0.01%) ⬆️ Carriedforward from ca32505

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota enabled auto-merge (squash) August 6, 2024 02:55
@satoshi-ota satoshi-ota merged commit 2705a63 into autowarefoundation:main Aug 6, 2024
29 of 30 checks passed
@satoshi-ota satoshi-ota deleted the fix/process-time-soa branch August 6, 2024 03:44
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2024
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Sep 3, 2024
satoshi-ota added a commit that referenced this pull request Sep 3, 2024
…move invalid small shift lines (#8721)

* Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (#8344)"

This reverts commit 2705a63.

* fix(static_obstacle_avoidance): remove invalid small shift lines

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…move invalid small shift lines (autowarefoundation#8721)

* Revert "fix(static_obstacle_avoidance): remove invalid small shift lines (autowarefoundation#8344)"

This reverts commit 2705a63.

* fix(static_obstacle_avoidance): remove invalid small shift lines

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants