Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freespace_planner): disable randomly failing tests #8337

Conversation

maxime-clem
Copy link
Contributor

Description

Some tests in the autoware_freespace_planner package are randomly failing (both in the CI and locally).
This PR disable them so that they do not bother other PRs. A proper fix will be made later.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 2, 2024
@maxime-clem maxime-clem enabled auto-merge (squash) August 2, 2024 08:26
Copy link

github-actions bot commented Aug 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 2, 2024
@takayuki5168
Copy link
Contributor

@maxime-clem @mkquda
Thank you.
Please make Quda-san be the maintainer of packages he got familiar with.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d849e9) to head (b3ee80c).
Report is 999 commits behind head on main.

Files Patch % Lines
...ner/test/test_freespace_planner_node_interface.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #8337       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.09%     
==========================================
  Files        1967     118     -1849     
  Lines      135941   12482   -123459     
  Branches    42122    1465    -40657     
==========================================
- Hits        20520       1    -20519     
+ Misses      92700   12481    -80219     
+ Partials    22721       0    -22721     
Flag Coverage Δ
differential <0.01% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 3e79b8f into autowarefoundation:main Aug 5, 2024
29 of 30 checks passed
@maxime-clem maxime-clem deleted the fix/test_freespace_planner_node_interface branch August 6, 2024 05:08
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…ation#8337)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants