Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_velocity_speed_bump_module): fix uninitMemberVar #8320

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck uninitMemberVar warnings.

planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_module/src/occlusion_spot_utils.hpp:166:3: warning: Member variable 'PossibleCollisionInfo::obstacle_info' is not initialized in the constructor. [uninitMemberVar]
  PossibleCollisionInfo() = default;
  ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc August 1, 2024 08:48
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 1, 2024
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 marked this pull request as draft August 1, 2024 09:05
@kobayu858 kobayu858 marked this pull request as ready for review August 2, 2024 04:25
@kobayu858 kobayu858 marked this pull request as draft August 2, 2024 04:28
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
…emb4/autoware.universe into fix/cppcheck_uninitMemberVar_pla-5
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 marked this pull request as ready for review August 2, 2024 04:39
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 13.63%. Comparing base (3d849e9) to head (9bd21cd).
Report is 971 commits behind head on main.

Files Patch % Lines
...occlusion_spot_module/src/occlusion_spot_utils.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8320      +/-   ##
==========================================
- Coverage   15.09%   13.63%   -1.47%     
==========================================
  Files        1967      451    -1516     
  Lines      135941    37521   -98420     
  Branches    42122     6001   -36121     
==========================================
- Hits        20520     5115   -15405     
+ Misses      92700    31864   -60836     
+ Partials    22721      542   -22179     
Flag Coverage Δ
differential 13.63% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit f79f9bb into autowarefoundation:main Aug 5, 2024
29 of 30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 5, 2024
autowarefoundation#8320)

* fix:uninitMemberVar

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:uninitMemberVar

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_uninitMemberVar_pla-5 branch August 13, 2024 06:19
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
autowarefoundation#8320)

* fix:uninitMemberVar

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:uninitMemberVar

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants