Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): use different rss param to deal with parked vehicle #8316

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Aug 1, 2024

Description

Available RSS parameters is too conservative for parked vehicle.
In this PR, RSS parameters for parked vehicle is separated to relax the criteria.

Related links

autowarefoundation/autoware_launch#1104

How was this PR tested?

  1. With PSIM
  2. TIER IV internal link

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added safety_check.parked.expected_front_deceleration double -1.0 The front object's maximum deceleration when the front vehicle perform sudden braking.
Added safety_check.parked.expected_rear_deceleration double -2.0 The rear object's maximum deceleration when the rear vehicle perform sudden braking.
Added safety_check.parked.rear_vehicle_reaction_time double 1.0 The reaction time of the rear vehicle driver which starts from the driver noticing the sudden braking of the front vehicle until the driver step on the brake.
Added safety_check.parked.rear_vehicle_safety_time_margin double 0.8 The time buffer for the rear vehicle to come into complete stop when its driver perform sudden braking.
Added safety_check.parked.lateral_distance_max_threshold double 1.0 The lateral distance threshold that is used to determine whether lateral distance between two object is enough and whether lane change is safe.
Added safety_check.parked.longitudinal_distance_min_threshold double 3.0 The longitudinal distance threshold that is used to determine whether longitudinal distance between two object is enough and whether lane change is safe.
Added safety_check.parked.longitudinal_velocity_delta_time double 0.8 The time multiplier that is used to compute the actual gap between vehicle at each predicted points (not RSS distance)

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 👍

@@ -2069,9 +2069,14 @@ PathSafetyStatus NormalLaneChange::isLaneChangePathSafe(
const auto obj_predicted_paths = utils::path_safety_checker::getPredictedPathFromObj(
obj, lane_change_parameters_->use_all_predicted_path);
auto is_safe = true;
const auto selected_rss_param =
(obj.initial_twist.twist.linear.x <=
lane_change_parameters_->prepare_segment_ignore_object_velocity_thresh)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) prepare_segment_ignore_object_velocity_thresh this parameter should probably be renamed since the object is not ignored (can be done in a future PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I plan to rename it to something else in the later PR.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the use-different-rss-for-parked-vehicle branch from 2ba4a22 to b5e22ea Compare August 2, 2024 02:42
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the use-different-rss-for-parked-vehicle branch from b5e22ea to 3dfcc0e Compare August 2, 2024 07:42
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 2, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Aug 2, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) August 2, 2024 07:49
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 10.96%. Comparing base (3d849e9) to head (3dfcc0e).
Report is 976 commits behind head on main.

Files Patch % Lines
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8316       +/-   ##
===========================================
- Coverage   15.09%   10.96%    -4.14%     
===========================================
  Files        1967      267     -1700     
  Lines      135941    27475   -108466     
  Branches    42122     4864    -37258     
===========================================
- Hits        20520     3012    -17508     
+ Misses      92700    24087    -68613     
+ Partials    22721      376    -22345     
Flag Coverage Δ
differential 10.96% <84.21%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit f07fa8e into autowarefoundation:main Aug 2, 2024
39 of 42 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the use-different-rss-for-parked-vehicle branch August 2, 2024 08:36
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Aug 2, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 5, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Aug 7, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Aug 14, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Aug 14, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Aug 14, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Aug 15, 2024
autowarefoundation#8316)

* different rss value for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Documentation and config file update

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants