fix(traffic_light_visualizer): remove cerr temporarily to avoid flooding logs #8294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing logs Signed-off-by: kminoda <koji.minoda@tier4.jp>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kminoda
added
the
tag:run-build-and-test-differential
6 tasks
Signed-off-by: kminoda <koji.minoda@tier4.jp>
|
@yukkysaito Hi, would you briefly check this PR? |
yukkysaito
approved these changes
Aug 1, 2024
Shin-kyoto
approved these changes
Aug 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8294 +/- ##
==========================================
- Coverage 29.31% 0.00% -29.32%
==========================================
Files 1609 13 -1596
Lines 119413 442 -118971
Branches 51480 57 -51423
==========================================
- Hits 35000 0 -35000
+ Misses 75112 442 -74670
+ Partials 9301 0 -9301
☔ View full report in Codecov by Sentry. |
|
@kminoda I think this PR can be merged. |
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…ing logs (autowarefoundation#8294) * fix(traffic_light_visualizer): remove cerr temporarily to avoid flooding logs Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix precommit Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #7924 as a very short term way, as this issue is critical in our environment
Related links
#7924
How was this PR tested?
Not tested since I could not even reproduce the flooding error messages.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.