Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_probabilistic_occupancy_grid_map): fix functionConst #8289

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck functionConst warnings.

perception/autoware_probabilistic_occupancy_grid_map/lib/fusion_policy/fusion_policy.cpp:205:10: style: inconclusive: Technically the member function 'autoware::occupancy_grid_map::fusion_policy::dempster_shafer_fusion::dempsterShaferOccupancy::calcK' can be const. [functionConst]
  double calcK(const dempsterShaferOccupancy & other)
         ^

perception/autoware_probabilistic_occupancy_grid_map/lib/fusion_policy/fusion_policy.cpp:210:10: style: inconclusive: Technically the member function 'autoware::occupancy_grid_map::fusion_policy::dempster_shafer_fusion::dempsterShaferOccupancy::calcOccupied' can be const. [functionConst]
  double calcOccupied(const dempsterShaferOccupancy & other)
         ^

perception/autoware_probabilistic_occupancy_grid_map/lib/fusion_policy/fusion_policy.cpp:215:10: style: inconclusive: Technically the member function 'autoware::occupancy_grid_map::fusion_policy::dempster_shafer_fusion::dempsterShaferOccupancy::calcEmpty' can be const. [functionConst]
  double calcEmpty(const dempsterShaferOccupancy & other)
         ^

perception/autoware_probabilistic_occupancy_grid_map/lib/fusion_policy/fusion_policy.cpp:243:10: style: inconclusive: Technically the member function 'autoware::occupancy_grid_map::fusion_policy::dempster_shafer_fusion::dempsterShaferOccupancy::getPignisticProbability' can be const. [functionConst]
  double getPignisticProbability() { return occupied + unknown / 2.0; }
         ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 31, 2024
@kobayu858 kobayu858 requested a review from veqcc July 31, 2024 08:31
@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 31, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.19%. Comparing base (3d849e9) to head (7f3e411).
Report is 948 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8289       +/-   ##
===========================================
+ Coverage   15.09%   29.19%   +14.10%     
===========================================
  Files        1967     1600      -367     
  Lines      135941   117424    -18517     
  Branches    42122    50610     +8488     
===========================================
+ Hits        20520    34284    +13764     
+ Misses      92700    73963    -18737     
+ Partials    22721     9177    -13544     
Flag Coverage Δ *Carryforward flag
differential 10.17% <100.00%> (?)
total 29.19% <ø> (+14.10%) ⬆️ Carriedforward from 5093495

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobayu858 kobayu858 merged commit f3dfbaf into autowarefoundation:main Aug 4, 2024
39 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 5, 2024
…towarefoundation#8289)

fix:functionConst

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_functionConst_per-12 branch August 13, 2024 06:19
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…towarefoundation#8289)

fix:functionConst

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants