fix(autoware_lidar_centerpoint): place device vector in CUDA device system #8272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
amadeuszsz
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8272 +/- ##
===========================================
+ Coverage 15.09% 29.18% +14.09%
===========================================
Files 1967 1602 -365
Lines 135941 117583 -18358
Branches 42122 50674 +8552
===========================================
+ Hits 20520 34318 +13798
+ Misses 92700 74082 -18618
+ Partials 22721 9183 -13538
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 5, 2024
…ystem (autowarefoundation#8272) Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…ystem (autowarefoundation#8272) Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CUDA 12.5 makes device vectors works with CUDA target only by default. Before this PR it works, but it shouldn't. As maintainer says no Thrust header can be included in a host-only TU.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.