fix(diagnostic_graph_aggregator): fix cppcheck warning of functionStatic #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: taisa1 <kento.osa@tier4.jp>
github-actions
bot
added
the
component:system
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
atsushi421
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8266 +/- ##
==========================================
- Coverage 29.29% 29.14% -0.16%
==========================================
Files 1609 1607 -2
Lines 119415 117391 -2024
Branches 51481 50504 -977
==========================================
- Hits 34988 34213 -775
+ Misses 75118 74004 -1114
+ Partials 9309 9174 -135
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This function is prepared for future implementation. Since I plan to update member variables, please leave it as it is. |
Signed-off-by: taisa1 <kento.osa@tier4.jp>
|
I understand. To avoid it remaining as a warning, I changed it to suppress a warning with an inline comment. Could you check this? @isamu-takagi |
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…tic (autowarefoundation#8266) * fix: deal with functionStatic warning Signed-off-by: taisa1 <kento.osa@tier4.jp> * suppress warning by comment Signed-off-by: taisa1 <kento.osa@tier4.jp> --------- Signed-off-by: taisa1 <kento.osa@tier4.jp>
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…tic (autowarefoundation#8266) * fix: deal with functionStatic warning Signed-off-by: taisa1 <kento.osa@tier4.jp> * suppress warning by comment Signed-off-by: taisa1 <kento.osa@tier4.jp> --------- Signed-off-by: taisa1 <kento.osa@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix based on cppcheck warning
functionStatic.Related links
How was this PR tested?
Only checked if build succeeded.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.