Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(yabloc_common): remove unnecessary pub/sub depth for transient_local #8248

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jul 30, 2024

Description

Several publishers/subscribers were specified with QoS as transient_local and depth=10.
Since they handle only the most recent data, so depth=10 is unnecessary.

This PR optimizes the QoS by reducing the depth to 1.

Related links

Parent Issue:

  • nothing

How was this PR tested?

1 . Confirmed that yabloc works as conventional in logging_simulator

ros2 launch autoware_launch logging_simulator.launch.xml \
    map_path:=$HOME/Maps/nishishinjuku \
    vehicle_model:=sample_vehicle \
    sensor_model:=awsim_sensor_kit \
    pose_source:=yabloc

rosbag&map
This rosbag link is quated from Driving Log Replayer Tutorial

2. Confirmed that the depth of all transient_local topics has been set to 1

cd autoware/src/universe/autoware.universe/localization/yabloc
grep transient_local . -r 

then, the followings are printed

./yabloc_common/src/ground_server/ground_server_core.cpp:  const rclcpp::QoS map_qos = rclcpp::QoS(1).transient_local().reliable();
./yabloc_common/src/ll2_decomposer/ll2_decomposer_core.cpp:  const rclcpp::QoS latch_qos = rclcpp::QoS(1).transient_local();
./yabloc_common/src/ll2_decomposer/ll2_decomposer_core.cpp:  const rclcpp::QoS map_qos = rclcpp::QoS(1).transient_local().reliable();
./yabloc_pose_initializer/src/camera/camera_pose_initializer_core.cpp:  const rclcpp::QoS map_qos = rclcpp::QoS(1).transient_local().reliable();

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jul 30, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@KYabuuchi KYabuuchi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.20%. Comparing base (5093495) to head (7b89fb9).
Report is 13 commits behind head on main.

Files Patch % Lines
..._common/src/ll2_decomposer/ll2_decomposer_core.cpp 0.00% 2 Missing ⚠️
...oc_common/src/ground_server/ground_server_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8248      +/-   ##
==========================================
- Coverage   29.24%   29.20%   -0.04%     
==========================================
  Files        1600     1601       +1     
  Lines      117738   117573     -165     
  Branches    50720    50668      -52     
==========================================
- Hits        34427    34338      -89     
+ Misses      74120    74050      -70     
+ Partials     9191     9185       -6     
Flag Coverage Δ *Carryforward flag
differential 9.35% <0.00%> (?)
total 29.19% <ø> (-0.05%) ⬇️ Carriedforward from 5093495

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KYabuuchi KYabuuchi changed the title fix(yabloc_common): remove unnecessary pub/sub depth for transient_local perf(yabloc_common): remove unnecessary pub/sub depth for transient_local Jul 30, 2024
@KYabuuchi KYabuuchi marked this pull request as ready for review July 30, 2024 08:05
@KYabuuchi KYabuuchi merged commit 3e4254e into autowarefoundation:main Jul 31, 2024
53 checks passed
@KYabuuchi KYabuuchi deleted the fix/remove_unnecessary_pubsub_depth branch July 31, 2024 06:55
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 5, 2024
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants