fix(autoware_traffic_light_visualization): fix passedByValue

[kobayu858]

Description

This is a fix based on cppcheck passedByValue warnings

perception/traffic_light_visualization/src/traffic_light_map_visualizer/node.cpp:43:52: performance: Function parameter 'attr_str' should be passed by const reference. [passedByValue]
  const lanelet::ConstPoint3d p, const std::string attr_str, const std::string value_str)
                                                   ^

perception/traffic_light_visualization/src/traffic_light_map_visualizer/node.cpp:43:80: performance: Function parameter 'value_str' should be passed by const reference. [passedByValue]
  const lanelet::ConstPoint3d p, const std::string attr_str, const std::string value_str)
                                                                               ^

perception/traffic_light_visualization/src/traffic_light_map_visualizer/node.cpp:54:88: performance: Function parameter 'ns' should be passed by const reference. [passedByValue]
  lanelet::ConstPoint3d p, visualization_msgs::msg::Marker * marker, const std::string ns,
                                                                                       ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.25%. Comparing base (6719f5f) to head (b6f20c0).
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8241   +/-   ##
=======================================
  Coverage   29.25%   29.25%           
=======================================
  Files        1600     1600           
  Lines      117744   117744           
  Branches    50716    50716           
=======================================
  Hits        34447    34447           
  Misses      74072    74072           
  Partials     9225     9225           

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <ø> (?)
total	29.25% <ø> (ø)		Carriedforward from 6719f5f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kobayu858]

@tzhong518 @yukkysaito

Please confirm the PR. Thank you very much.

[yukkysaito]

LGTM