fix(autoware_perception_rviz_plugin): fix passedByValue

[bathteayo]

Description

This is a fix based on cppcheck passedByValue warnings

common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp:462:21: performance: Function parameter 'label' should be passed by const reference. [passedByValue]
  const std::string label, const std_msgs::msg::ColorRGBA & color_rgba)
                    ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.13%. Comparing base (093c20c) to head (c36cf81).
Report is 64 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8192   +/-   ##
=======================================
  Coverage   29.13%   29.13%           
=======================================
  Files        1609     1609           
  Lines      118141   118141           
  Branches    50847    50847           
=======================================
  Hits        34425    34425           
  Misses      74508    74508           
  Partials     9208     9208           

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <ø> (?)
total	29.13% <ø> (ø)		Carriedforward from b373930

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[veqcc]

.hpp file should also be modified?

[kobayu858]

@veqcc
Indeed, the declaration and definition must match the type.
That is why I fixed it.

However, it is strange because the CI build was passed.

[YoshiRi]

LGTM