Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(centerpoint): add description for ml package params #8187

Merged
merged 8 commits into from
Jul 31, 2024
Merged

docs(centerpoint): add description for ml package params #8187

merged 8 commits into from
Jul 31, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 25, 2024 •
edited
Loading

Description

Add description for some parameters in CenterPoint

Related links

N/A

How was this PR tested?

N/A

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@kminoda
docs(lidar_centerpoint): add param description for ml packages
452d9df 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
update
effa7f6 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kminoda kminoda changed the title feat(centerpoint): add description for ml package params docs(centerpoint): add description for ml package params Jul 25, 2024
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 25, 2024
@kminoda kminoda marked this pull request as ready for review July 25, 2024 07:16
@kminoda kminoda requested a review from knzo25 as a code owner July 25, 2024 07:16
@kminoda
Copy link
Contributor Author

kminoda commented Jul 25, 2024

@knzo25 Hi, would you check this?

@kminoda
update
455583b 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda force-pushed the feat/centerpoint/add_description_for_ml_package_params branch from d8fb9f1 to 455583b Compare July 25, 2024 07:20
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.22%. Comparing base (3d849e9) to head (8ad7059).
Report is 943 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #8187       +/-   ##
===========================================
+ Coverage   15.09%   29.22%   +14.13%     
===========================================
  Files        1967     1601      -366     
  Lines      135941   117287    -18654     
  Branches    42122    50575     +8453     
===========================================
+ Hits        20520    34280    +13760     
+ Misses      92700    73785    -18915     
+ Partials    22721     9222    -13499
Flag Coverage Δ *Carryforward flag
differential 8.79% <ø> (?)
total 29.22% <ø> (+14.13%) ⬆️ Carriedforward from 69f7bbb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

knzo25
knzo25 requested changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments

kminoda and others added 2 commits July 29, 2024 11:32
@kminoda
reflect comments
7795acf 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
style(pre-commit): autofix
0ec25f0
@kminoda
Copy link
Contributor Author

kminoda commented Jul 31, 2024

@knzo25 friendly ping

@youtalk youtalk requested a review from knzo25 July 31, 2024 02:18
knzo25
knzo25 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kminoda
Sorry for the delay !
LGTM

@kminoda kminoda merged commit 26e01e9 into autowarefoundation:main Jul 31, 2024
30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 5, 2024
@kminoda @kyoichi-sugahara
docs(centerpoint): add description for ml package params (autowarefou…
f267ef2 
…ndation#8187)
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@kminoda @esteve
docs(centerpoint): add description for ml package params (autowarefou…
9478b56 
…ndation#8187)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knzo25 knzo25 knzo25 approved these changes

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kminoda @knzo25