Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autoware_multi_object_tracker): add default values on the schema json #8179

Merged

Conversation

tby-udel
Copy link
Contributor

Description

Fixing the #7333 issue of the multi_object_tracker package.

  • Added the default values to 2 schema files.

Tests performed

Package built and launched locally.

Notes for reviewers

Nothing inside the src code part was changed, only updating schema file.

Interface changes

Parameter values are now required to be passed to the node when launched.

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@tby-udel
Copy link
Contributor Author

@technolojin I think this is caused by some parameters in schema files are lack of certain default values, I have updated the schema files. On github, it says that this branch has conflicting files "perception/multi_object_tracker/README.md", but I can't see any conflicts after I updated my local branch and merged main into this branch.

@technolojin
Copy link
Contributor

@tby-udel
I think it is better to rebase to the latest main.

@technolojin technolojin self-assigned this Jul 26, 2024
@technolojin
Copy link
Contributor

@tby-udel
Thank you for your additional work.

We had to rename all the package names to have prefix autoware_, and the works are done.
I am sorry for late response and confusing changes.

Your current branch contains 212 commits and those are by merging the main to your branch.
Therefore, I suggest to rebase your commits to the latest main branch, to that the PR contains only your changes.

@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Aug 7, 2024
@technolojin technolojin changed the title Multi object tracker branch docs(autoware_multi_object_tracker): add default values on the schema json Aug 7, 2024
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin enabled auto-merge (squash) August 7, 2024 05:18
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 7, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.76%. Comparing base (022bd17) to head (9971a53).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8179      +/-   ##
==========================================
+ Coverage   23.74%   23.76%   +0.01%     
==========================================
  Files        1378     1379       +1     
  Lines      101354   101322      -32     
  Branches    38522    38503      -19     
==========================================
+ Hits        24068    24076       +8     
+ Misses      74870    74766     -104     
- Partials     2416     2480      +64     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.76% <ø> (+0.01%) ⬆️ Carriedforward from b967eae

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit 3e3df5b into autowarefoundation:main Aug 8, 2024
29 of 30 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Aug 9, 2024
… json (autowarefoundation#8179)

* Refractored the parameters, build the schema file, updated the readme file.

Signed-off-by: Boyang <tby@udel.edu>

* style(pre-commit): autofix

---------

Signed-off-by: Boyang <tby@udel.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
… json (autowarefoundation#8179)

* Refractored the parameters, build the schema file, updated the readme file.

Signed-off-by: Boyang <tby@udel.edu>

* style(pre-commit): autofix

---------

Signed-off-by: Boyang <tby@udel.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@technolojin
Copy link
Contributor

technolojin commented Aug 14, 2024

the error persists
https://autowarefoundation.github.io/autoware.universe/main/perception/autoware_multi_object_tracker/

schema/input_channels.schema.json still missing the default values

fix PR #8473

xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
… json (autowarefoundation#8179)

* Refractored the parameters, build the schema file, updated the readme file.

Signed-off-by: Boyang <tby@udel.edu>

* style(pre-commit): autofix

---------

Signed-off-by: Boyang <tby@udel.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: xtk8532704 <1041084556@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants