feat(evalautor): rename evaluator diag topics #8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
KeisukeShima,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
kyoichi-sugahara,
maxime-clem and
danielsanchezaran
as code owners
github-actions
bot
added
component:launch
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
added
the
tag:run-build-and-test-differential
|
@kyoichi-sugahara @maxime-clem |
maxime-clem
approved these changes
Jul 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8152 +/- ##
==========================================
- Coverage 29.13% 29.12% -0.01%
==========================================
Files 1609 1611 +2
Lines 118147 118176 +29
Branches 50850 50853 +3
==========================================
+ Hits 34420 34424 +4
- Misses 74480 74506 +26
+ Partials 9247 9246 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xtk8532704
approved these changes
Jul 23, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
ktro2828,
miursh and
YoshiRi
as code owners
This was referenced Jul 23, 2024
1 task
|
@kyoichi-sugahara |
kyoichi-sugahara
approved these changes
Jul 23, 2024
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 30, 2024
* feat(evalautor): rename evaluator diag topics Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * perception Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
shmpwk
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 30, 2024
* feat(evalautor): rename evaluator diag topics (autowarefoundation#8152) * feat(evalautor): rename evaluator diag topics Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * perception Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix: adapt v0.29.0 control launcher Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 31, 2024
* feat(evalautor): rename evaluator diag topics Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * perception Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
hayato-m126
added a commit
to tier4/driving_log_replayer_v2
that referenced
this pull request
Jul 31, 2024
hayato-m126
added a commit
to tier4/driving_log_replayer_v2
that referenced
this pull request
Aug 2, 2024
* feat: planning control node * feat: update evaluation logic * feat: update evaluation logic * fix: cast string * fix: field * feat: add unit test * chore: add temporary logic * fix: lane condition * fix: lane s condition * chore: allow empty KinematicCondition * chore: add output decision * chore: update sample * chore: pre-commit * feat: add remap /localization/acceleration * docs: update * docs: update can msg * feat: support LaunchPerception and LaunchPlanning * feat: remap topic in bag * fix: pre-commit * chore: update status length check * fix: remap * docs: update document * docs: update sample * feat: update unit test * fix: local variable lane_info_tuple referenced before assignment * feat: update scenario format and enable/disable component * feat: update topic name autowarefoundation/autoware.universe#8152 * fix: pre-commit
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
* feat(evalautor): rename evaluator diag topics Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * perception Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/diagnostic/* topic name is confusing because theare are /diagnostics/* topics.
and in the future, we plan to separate metrics (just calculate value) and diagnostics (compare with threshould).
Related links
Parent Issue:
Private Links:
How was this PR tested?
2024/07/23 https://evaluation.tier4.jp/evaluation/reports/fda048c3-d0c1-549c-91e6-9a7444741bb8/?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.