fix(autoware_map_based_prediction): fix argument order #8031

yucedagonurcan · 2024-07-14T13:33:46Z

Description

Original code invokes getFrenetPoint function with wrong order of arguments:

Original:

getFrenetPoint(object, ref_path, speed_limit, duration);

New:

getFrenetPoint(object, ref_path, duration, speed_limit);

Decleration of the function getFrenetPoint:

FrenetPoint PathGenerator::getFrenetPoint(
  const TrackedObject & object, const PosePath & ref_path, const double duration,
  const double speed_limit) const

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions · 2024-07-14T13:34:04Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

Shin-kyoto · 2024-08-01T16:40:11Z

Thank you for your PR!!

I checked your PR and I confirmed that your PR appropriately resolves the bug.

@YoshiRi @ktro2828 Can you check this PR as maintainer? 🙏

ktro2828

LGTM

ktro2828 · 2024-08-02T06:36:14Z

@yucedagonurcan Code looks good but you need to pass DCO. Please contain sign-off proof on your commit message. Could you fix that? https://github.com/apps/dco

codecov · 2024-08-02T06:39:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.78%. Comparing base (3d849e9) to head (6d71e49).
Report is 981 commits behind head on main.

Files	Patch %	Lines
...toware_map_based_prediction/src/path_generator.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8031       +/-   ##
===========================================
+ Coverage   15.09%   28.78%   +13.69%     
===========================================
  Files        1967     1610      -357     
  Lines      135941   117851    -18090     
  Branches    42122    50765     +8643     
===========================================
+ Hits        20520    33928    +13408     
+ Misses      92700    74742    -17958     
+ Partials    22721     9181    -13540

Flag	Coverage Δ		*Carryforward flag
differential	`1.12% <0.00%> (?)`
total	`28.95% <0.00%> (+13.86%)`	⬆️	Carriedforward from 0eae67c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

YoshiRi

Thanks! LGTM

…enetPoint()` Signed-off-by: yucedagonurcan <onur@adastec.com>

…ation#8031) fix(autoware_map_based_prediction): fix argument order in call `getFrenetPoint()` Signed-off-by: yucedagonurcan <onur@adastec.com> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com>

…performance of map_based_prediction (#1464) * fix(autoware_map_based_prediction): fix argument order (autowarefoundation#8031) fix(autoware_map_based_prediction): fix argument order in call `getFrenetPoint()` Signed-off-by: yucedagonurcan <onur@adastec.com> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> * perf(map_based_prediction): remove unncessary withinRoadLanelet() (autowarefoundation#8403) Signed-off-by: Mamoru Sobue <hilo.soblin@gmail.com> * perf(map_based_prediction): create a fence LineString layer and use rtree query (autowarefoundation#8406) use fence layer Signed-off-by: Mamoru Sobue <hilo.soblin@gmail.com> * perf(map_based_prediction): apply lerp instead of spline (autowarefoundation#8416) perf: apply lerp interpolation instead of spline Signed-off-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> * perf(autoware_map_based_prediction): improve orientation calculation and resample converted path (autowarefoundation#8427) * refactor: improve orientation calculation and resample converted path with linear interpolation Simplify the calculation of the orientation for each pose in the convertPathType function by directly calculating the sine and cosine of half the yaw angle. This improves efficiency and readability. Also, improve the resampling of the converted path by using linear interpolation for better performance. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> * Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> * perf(map_based_prediction): improve world to map transform calculation (autowarefoundation#8413) * perf(map_based_prediction): improve world to map transform calculation 1. remove unused transforms 2. make transform loading late as possible Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * perf(map_based_prediction): get transform only when it is necessary Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat(autoware_universe_utils): add LRU Cache (autowarefoundation#8456) Signed-off-by: Yukinari Hisaki <42021302+yhisaki@users.noreply.github.com> * perf(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType (autowarefoundation#8461) feat(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType Signed-off-by: Yukinari Hisaki <42021302+yhisaki@users.noreply.github.com> * fix(autoware_map_based_prediction): use surrounding_crosswalks instead of external_surrounding_crosswalks (autowarefoundation#8467) Signed-off-by: Yukinari Hisaki <42021302+yhisaki@users.noreply.github.com> --------- Signed-off-by: Mamoru Sobue <hilo.soblin@gmail.com> Signed-off-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Yukinari Hisaki <42021302+yhisaki@users.noreply.github.com> Co-authored-by: Onur Can Yücedağ <onur@adastec.com> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Co-authored-by: Yukinari Hisaki <42021302+yhisaki@users.noreply.github.com>

…ation#8031) fix(autoware_map_based_prediction): fix argument order in call `getFrenetPoint()` Signed-off-by: yucedagonurcan <onur@adastec.com> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Kotaro Uetake <60615504+ktro2828@users.noreply.github.com> Signed-off-by: xtk8532704 <1041084556@qq.com>

yucedagonurcan requested review from ktro2828, kyoichi-sugahara, takayuki5168, tkimura4 and YoshiRi as code owners July 14, 2024 13:33

github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 14, 2024

Shin-kyoto added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 1, 2024

ktro2828 approved these changes Aug 2, 2024

View reviewed changes

YoshiRi approved these changes Aug 2, 2024

View reviewed changes

fix(autoware_map_based_prediction): fix argument order in call `getFr…

c2ed3e2

…enetPoint()` Signed-off-by: yucedagonurcan <onur@adastec.com>

yucedagonurcan force-pushed the main branch from d4a8633 to c2ed3e2 Compare August 4, 2024 15:11

yucedagonurcan requested a review from ktro2828 August 4, 2024 15:14

Shin-kyoto approved these changes Aug 5, 2024

View reviewed changes

Shin-kyoto and others added 2 commits August 5, 2024 10:35

Merge branch 'main' into main

6d71e49

Merge branch 'main' into main

e004e84

ktro2828 enabled auto-merge (squash) August 7, 2024 01:06

ktro2828 approved these changes Aug 7, 2024

View reviewed changes

ktro2828 merged commit 8cc3e49 into autowarefoundation:main Aug 7, 2024
23 of 24 checks passed

technolojin mentioned this pull request Aug 15, 2024

perf(autoware_map_based_prediction autoware_universe_utils): improve performance of map_based_prediction tier4/autoware.universe#1464

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(autoware_map_based_prediction): fix argument order #8031

fix(autoware_map_based_prediction): fix argument order #8031

yucedagonurcan commented Jul 14, 2024

github-actions bot commented Jul 14, 2024 •

edited

Loading

Shin-kyoto commented Aug 1, 2024

ktro2828 left a comment

ktro2828 commented Aug 2, 2024

codecov bot commented Aug 2, 2024 •

edited

Loading

YoshiRi left a comment

fix(autoware_map_based_prediction): fix argument order #8031

fix(autoware_map_based_prediction): fix argument order #8031

Conversation

yucedagonurcan commented Jul 14, 2024

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

github-actions bot commented Jul 14, 2024 • edited Loading

Shin-kyoto commented Aug 1, 2024

ktro2828 left a comment

Choose a reason for hiding this comment

ktro2828 commented Aug 2, 2024

codecov bot commented Aug 2, 2024 • edited Loading

Codecov Report

YoshiRi left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 14, 2024 •

edited

Loading

codecov bot commented Aug 2, 2024 •

edited

Loading