Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(velocity_smoother): not resample debug_trajectories is not used #8030

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 13, 2024

Description

Not resample debug_trajectories if not published.
The following is the examples cases of the time to reduce.

case1

            │   ├── resample: 0.61 [ms]
            │   ├── resample: 0.63 [ms]
            │   ├── resample: 0.62 [ms]

case2

            │   ├── resample: 0.87 [ms]
            │   ├── resample: 0.71 [ms]
            │   ├── resample: 0.71 [ms]

case3

            │   ├── resample: 1.20 [ms]
            │   ├── resample: 1.29 [ms]
            │   ├── resample: 1.33 [ms]

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 13, 2024
Copy link

github-actions bot commented Jul 13, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 marked this pull request as ready for review July 30, 2024 06:58
@takayuki5168 takayuki5168 changed the title perf(velocity_smoother): perf(velocity_smoother): not resample debug_trajectories is not used Jul 30, 2024
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 30, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 28.92%. Comparing base (0eae67c) to head (c644ec3).
Report is 210 commits behind head on main.

Files Patch % Lines
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 0.00% 9 Missing and 1 partial ⚠️
planning/autoware_velocity_smoother/src/node.cpp 16.66% 5 Missing ⚠️
...lanner_common/src/utilization/trajectory_utils.cpp 0.00% 0 Missing and 1 partial ⚠️
...autoware_motion_velocity_planner_node/src/node.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8030      +/-   ##
==========================================
- Coverage   28.94%   28.92%   -0.02%     
==========================================
  Files        1606     1610       +4     
  Lines      117446   117498      +52     
  Branches    50463    50466       +3     
==========================================
- Hits        33993    33991       -2     
- Misses      74281    74335      +54     
  Partials     9172     9172              
Flag Coverage Δ *Carryforward flag
differential 18.54% <5.55%> (?)
total 28.94% <ø> (+<0.01%) ⬆️ Carriedforward from 0eae67c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit da61d22 into autowarefoundation:main Jul 30, 2024
28 of 30 checks passed
@takayuki5168 takayuki5168 deleted the perf/velocity-smoother branch July 30, 2024 10:38
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2024
…utowarefoundation#8030)

* not resample debug_trajectories if not published

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update dependant packages

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…utowarefoundation#8030)

* not resample debug_trajectories if not published

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update dependant packages

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants