-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(velocity_smoother): use ProxQP for faster optimization #8028
perf(velocity_smoother): use ProxQP for faster optimization #8028
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
627e122
to
f9c6238
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8028 +/- ##
==========================================
- Coverage 29.24% 29.11% -0.13%
==========================================
Files 1600 1605 +5
Lines 117738 117823 +85
Branches 50720 50699 -21
==========================================
- Hits 34427 34308 -119
- Misses 74120 74333 +213
+ Partials 9191 9182 -9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f9c6238
to
6fd2c38
Compare
02d97c6
to
769d8f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to only do the change for the jerk filtered smoother ?
What about the L_2 and L_inf pseudo jerk smoother ?
@maxime-clem First of all, it's a bit hard to check whether the behavior won't change with this change. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
769d8f8
to
d14bb37
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…foundation#8028) * perf(velocity_smoother): use ProxQP for faster optimization Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * consider max_iteration Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * disable warm start Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…foundation#8028) * perf(velocity_smoother): use ProxQP for faster optimization Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * consider max_iteration Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * disable warm start Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
Use ProxQP instead of OSQPfor the velocity optimization.
Enabling warm start makes several scenarios fail due to the optimization failure as follows, so the warm start is disabled.
https://evaluation.tier4.jp/evaluation/reports/76156fc6-7529-5edf-b8f8-de8589118b37?project_id=prd_jt
Related links
How was this PR tested?
scenario test: https://evaluation.tier4.jp/evaluation/reports/6b10df3c-2ef3-5b69-9955-aee37d8b6c2b?project_id=prd_jt
psim
Before (with OSQP) (with warm start)
After with OSQP (with warm start)
After with ProxQP (without warm start)
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.