Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_velocity_intersection_module): fix funcArgNamesDifferent #8023

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck funcArgNamesDifferent warnings

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/object_manager.cpp:76:58: style: inconclusive: Function 'initialize' argument 1 names different: declaration 'predicted_object' definition 'object'. [funcArgNamesDifferent]
  const autoware_perception_msgs::msg::PredictedObject & object,
                                                         ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/object_manager.cpp:77:40: style: inconclusive: Function 'initialize' argument 2 names different: declaration 'attention_lanelet_opt' definition 'attention_lanelet_opt_'. [funcArgNamesDifferent]
  std::optional<lanelet::ConstLanelet> attention_lanelet_opt_,
                                       ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/object_manager.cpp:78:45: style: inconclusive: Function 'initialize' argument 3 names different: declaration 'stopline_opt' definition 'stopline_opt_'. [funcArgNamesDifferent]
  std::optional<lanelet::ConstLineString3d> stopline_opt_)
                                            ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/object_manager.cpp:88:44: style: inconclusive: Function 'update_safety' argument 1 names different: declaration 'unsafe_interval_opt' definition 'unsafe_interval'. [funcArgNamesDifferent]
  const std::optional<CollisionInterval> & unsafe_interval,
                                           ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/object_manager.cpp:89:44: style: inconclusive: Function 'update_safety' argument 2 names different: declaration 'safe_interval_opt' definition 'safe_interval'. [funcArgNamesDifferent]
  const std::optional<CollisionInterval> & safe_interval, const bool safe_under_traffic_control)
                                           ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/object_manager.cpp:197:51: style: inconclusive: Function 'registerObject' argument 4 names different: declaration 'is_parked' definition 'is_parked_vehicle'. [funcArgNamesDifferent]
  const bool belong_intersection_area, const bool is_parked_vehicle)
                                                  ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/object_manager.cpp:217:51: style: inconclusive: Function 'registerExistingObject' argument 4 names different: declaration 'is_parked' definition 'is_parked_vehicle'. [funcArgNamesDifferent]
  const bool belong_intersection_area, const bool is_parked_vehicle,
                                                  ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection_collision.cpp:402:50: style: inconclusive: Function 'cutPredictPathWithinDuration' argument 3 names different: declaration 'predicted_path' definition 'path'. [funcArgNamesDifferent]
  autoware_perception_msgs::msg::PredictedPath * path) const
                                                 ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection_collision.cpp:809:53: style: inconclusive: Function 'calcIntersectionPassingTime' argument 4 names different: declaration 'debug_ttc_array' definition 'ego_ttc_array'. [funcArgNamesDifferent]
  tier4_debug_msgs::msg::Float64MultiArrayStamped * ego_ttc_array) const
                                                    ^

planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection_prepare_data.cpp:854:26: style: inconclusive: Function 'generateDetectionLaneDivisions' argument 1 names different: declaration 'detection_lanelets' definition 'detection_lanelets_all'. [funcArgNamesDifferent]
  lanelet::ConstLanelets detection_lanelets_all,
                         ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc July 12, 2024 11:32
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.92%. Comparing base (65c039d) to head (4ad327d).
Report is 227 commits behind head on main.

Files Patch % Lines
...elocity_intersection_module/src/object_manager.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8023      +/-   ##
==========================================
- Coverage   28.93%   28.92%   -0.02%     
==========================================
  Files        1601     1606       +5     
  Lines      117270   117323      +53     
  Branches    50302    50302              
==========================================
+ Hits        33933    33934       +1     
- Misses      74175    74227      +52     
  Partials     9162     9162              
Flag Coverage Δ *Carryforward flag
differential 13.38% <0.00%> (?)
total 28.93% <ø> (+<0.01%) ⬆️ Carriedforward from 660f851

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 requested a review from veqcc July 16, 2024 06:34
@kobayu858
Copy link
Contributor Author

@kyoichi-sugahara @soblin @shmpwk @takayuki5168 @tkimura4

Please confirm the PR. Thank you very much.

Copy link
Contributor

@veqcc veqcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kobayu858 kobayu858 requested a review from soblin July 31, 2024 04:09
@kobayu858
Copy link
Contributor Author

@soblin
Please confirm the PR. Thank you very much.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc July 31, 2024 06:53
@kobayu858 kobayu858 merged commit b840acf into autowarefoundation:main Aug 1, 2024
29 of 30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 5, 2024
…Different (autowarefoundation#8023)

* fix:funcArgNamesDifferent

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:funcArgNamesDifferent

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* refactor:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:funcArgNamesDifferent

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_funcArgNamesDifferent_pla-9 branch August 13, 2024 06:18
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…Different (autowarefoundation#8023)

* fix:funcArgNamesDifferent

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:funcArgNamesDifferent

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* refactor:clang format

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix:funcArgNamesDifferent

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants