Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tier4_pcl_extensions): modify build error in rolling #795

Merged
merged 2 commits into from
Apr 25, 2022
Merged

fix(tier4_pcl_extensions): modify build error in rolling #795

merged 2 commits into from
Apr 25, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 25, 2022 •
edited by kenji-miyake
Loading

Description

boost.h is deprecated.
PointCloudLibrary/pcl#4628

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

fix(tier4_pcl_extensions): modify build error in rolling
9a51b40 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 added ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release. labels Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #795 (4f9378b) into main (cf13680) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #795      +/-   ##
========================================
- Coverage   9.63%   9.61%   -0.03%     
========================================
  Files        907     907              
  Lines      56544   56673     +129     
  Branches    6694    6694              
========================================
  Hits        5448    5448              
- Misses     46601   46730     +129     
  Partials    4495    4495
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.63% <0.00%> (ø) Carriedforward from 9a51b40

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
localization/ndt/include/ndt/impl/omp.hpp 0.00% <ø> (ø)
localization/ndt/include/ndt/impl/pcl_generic.hpp 0.00% <ø> (ø)
localization/ndt/include/ndt/impl/pcl_modified.hpp 0.00% <ø> (ø)
localization/ndt/include/ndt/omp.hpp 0.00% <ø> (ø)
localization/ndt/include/ndt/pcl_generic.hpp 0.00% <ø> (ø)
localization/ndt/include/ndt/pcl_modified.hpp 0.00% <ø> (ø)
...pcl_modified/include/ndt_pcl_modified/impl/ndt.hpp 0.00% <0.00%> (ø)
.../ndt_pcl_modified/include/ndt_pcl_modified/ndt.hpp 0.00% <ø> (ø)
...include/ndt_scan_matcher/ndt_scan_matcher_core.hpp 0.00% <ø> (ø)
...can_matcher/include/ndt_scan_matcher/util_func.hpp 0.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977ba71...4f9378b. Read the comment docs.

@wep21 wep21 merged commit 1ba025f into autowarefoundation:main Apr 25, 2022
@wep21 wep21 deleted the fix/rolling-tier4-pcl-extensions branch April 25, 2022 06:46
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 26, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@wep21 @pre-commit-ci @boyali
fix(tier4_pcl_extensions): modify build error in rolling (tier4#795)
ab33c62 
* fix(tier4_pcl_extensions): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@wep21 @pre-commit-ci @boyali
fix(tier4_pcl_extensions): modify build error in rolling (tier4#795)
73d181f 
* fix(tier4_pcl_extensions): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@wep21 @pre-commit-ci @boyali
fix(tier4_pcl_extensions): modify build error in rolling (tier4#795)
cfcdfc5 
* fix(tier4_pcl_extensions): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@wep21 @pre-commit-ci @boyali
fix(tier4_pcl_extensions): modify build error in rolling (tier4#795)
954d3df 
* fix(tier4_pcl_extensions): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@v-nojiri7841-esol v-nojiri7841-esol mentioned this pull request May 12, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-miyake kenji-miyake kenji-miyake approved these changes

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto

@esteve esteve Awaiting requested review from esteve

Assignees
No one assigned
Labels
ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wep21 @kenji-miyake