Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_planning_rviz_plugin): memory leak #7164

Merged
merged 1 commit into from
May 30, 2024

Conversation

yukkysaito
Copy link
Contributor

Description

Every time the path length changed, it caused a memory leak. This PR fixes that.

I confirmed that the text is still displayed in the planning simulator. I also confirmed that leaks caused by movable text have been eliminated.

Related links

Tests performed

I confirmed that the text is still displayed in the planning simulator. I also confirmed that leaks caused by movable text have been eliminated.
after
image

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito requested a review from shmpwk May 29, 2024 17:45
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 29, 2024
@shmpwk shmpwk added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 29, 2024
@shmpwk shmpwk changed the title fix(tier4_planning_rviz_plugin) memory leak fix(tier4_planning_rviz_plugin): memory leak May 29, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk enabled auto-merge (squash) May 29, 2024 23:13
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shmpwk shmpwk merged commit b93f173 into autowarefoundation:main May 30, 2024
32 of 35 checks passed
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 30, 2024
fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 30, 2024
fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2024
fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
0x126 added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2024
#1507)

fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants