Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): add option to ignore overlaps in lane changes #6991

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented May 13, 2024

Description

Add an option to ignore all lanelets adjacent to the path lanelets where a lane change is possible. This prevents the out_of_lane from triggering stops during avoidance where the ego vehicle will overlap the adjacent lane.
Requires the launch PR: autowarefoundation/autoware_launch#986

Tests performed

Psim and bag replay.
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/659253fa-a67a-5341-a576-50afe030c401?project_id=prd_jt

Effects on system behavior

Reduce wrong stops caused by the out_of_lane module.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 13, 2024
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 13, 2024
@maxime-clem maxime-clem marked this pull request as ready for review May 13, 2024 05:51
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-clem maxime-clem merged commit d9b3df7 into autowarefoundation:main May 13, 2024
37 checks passed
@maxime-clem maxime-clem deleted the feat/out_of_lane-use_route_lanelets branch May 13, 2024 11:59
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 13, 2024
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request May 13, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 13, 2024
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…owarefoundation#6991)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants