fix(autoware_state_panel): fix message type for /api/autoware/get/engage #666

h-ohta · 2022-04-11T03:51:16Z

Description

fix message type for /api/autoware/get/engage

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

codecov · 2022-04-11T04:03:55Z

Codecov Report

Merging #666 (02c87ab) into main (718a040) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   10.61%   10.61%           
=======================================
  Files         734      734           
  Lines       51656    51656           
  Branches     6596     6596           
=======================================
  Hits         5482     5482           
  Misses      41714    41714           
  Partials     4460     4460

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`10.61% <0.00%> (ø)`		Carriedforward from 718a040

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718a040...02c87ab. Read the comment docs.

rej55

LGTM

…age (#666) * fix(autoware_state_panel): fix message type for /api/autoware/get/engage Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Back port .auto control packages (autowarefoundation#571) * Implement Lateral and Longitudinal Control Muxer * [autowarefoundation#570] Porting wf_simulator * [autowarefoundation#1189] Deactivate flaky test in 'trajectory_follower_nodes' * [autowarefoundation#1189] Fix flacky test in 'trajectory_follower_nodes/latlon_muxer' * [autowarefoundation#1057] Add osqp_interface package * [autowarefoundation#1057] Add library code for MPC-based lateral control * [autowarefoundation#1271] Use std::abs instead of abs * [autowarefoundation#1057] Implement Lateral Controller for Cargo ODD * [autowarefoundation#1246] Resolve "Test case names currently use snake_case but should be CamelCase" * [autowarefoundation#1325] Deactivate flaky smoke test in 'trajectory_follower_nodes' * [autowarefoundation#1058] Add library code of longitudinal controller * Fix build error for trajectory follower Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix build error for trajectory follower nodes Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autowarefoundation#1272] Add AckermannControlCommand support to simple_planning_simulator * [autowarefoundation#1058] Add Longitudinal Controller node * [autowarefoundation#1058] Rename velocity_controller -> longitudinal_controller * [autowarefoundation#1058] Update CMakeLists.txt for the longitudinal_controller_node * [autowarefoundation#1058] Add smoke test python launch file * [autowarefoundation#1058] Use LowPassFilter1d from trajectory_follower * [autowarefoundation#1058] Use autoware_auto_msgs * [autowarefoundation#1058] Changes for .auto (debug msg tmp fix, common func, tf listener) * [autowarefoundation#1058] Remove unused parameters * [autowarefoundation#1058] Fix ros test * [autowarefoundation#1058] Rm default params from declare_parameters + use autoware types * [autowarefoundation#1058] Use default param file to setup NodeOptions in the ros test * [autowarefoundation#1058] Fix docstring * [autowarefoundation#1058] Replace receiving a Twist with a VehicleKinematicState * [autowarefoundation#1058] Change class variables format to m_ prefix * [autowarefoundation#1058] Fix plugin name of LongitudinalController in CMakeLists.txt * [autowarefoundation#1058] Fix copyright dates * [autowarefoundation#1058] Reorder includes * [autowarefoundation#1058] Add some tests (~89% coverage without disabling flaky tests) * [autowarefoundation#1058] Add more tests (90+% coverage without disabling flaky tests) * [autowarefoundation#1058] Use Float32MultiArrayDiagnostic message for debug and slope * [autowarefoundation#1058] Calculate wheel_base value from vehicle parameters * [autowarefoundation#1058] Cleanup redundant logger setting in tests * [autowarefoundation#1058] Set ROS_DOMAIN_ID when running tests to prevent CI failures * [autowarefoundation#1058] Remove TF listener and use published vehicle state instead * [autowarefoundation#1058] Change smoke tests to use autoware_testing * [autowarefoundation#1058] Add plotjuggler cfg for both lateral and longitudinal control * [autowarefoundation#1058] Improve design documents * [autowarefoundation#1058] Disable flaky test * [autowarefoundation#1058] Properly transform vehicle state in longitudinal node * [autowarefoundation#1058] Fix TF buffer of lateral controller * [autowarefoundation#1058] Tuning of lateral controller for LGSVL * [autowarefoundation#1058] Fix formating * [autowarefoundation#1058] Fix /tf_static sub to be transient_local * [autowarefoundation#1058] Fix yaw recalculation of reverse trajs in the lateral controller * modify trajectory_follower for galactic build Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [autowarefoundation#1379] Update trajectory_follower * [autowarefoundation#1379] Update simple_planning_simulator * [autowarefoundation#1379] Update trajectory_follower_nodes * apply trajectory msg modification in control Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * move directory Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remote control/trajectory_follower level dorectpry Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove .iv trajectory follower Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use .auto trajectory_follower Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove .iv simple_planning_simulator & osqp_interface Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use .iv simple_planning_simulator & osqp_interface Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add tmp_autoware_auto_dependencies Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * tmporally add autoware_auto_msgs Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * apply .auto message split Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix build depend Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix packages using osqp * fix autoware_auto_geometry * ignore lint of some packages * ignore ament_lint of some packages * ignore lint/pre-commit of trajectory_follower_nodes * disable unit tests of some packages Co-authored-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Joshua Whitley <josh.whitley@autoware.org> Co-authored-by: Igor Bogoslavskyi <igor.bogoslavskyi@gmail.com> Co-authored-by: MIURA Yasuyuki <kokosabu@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * Fix message interface and tests of 'trajectory_follower_nodes' (autowarefoundation#617) * Update longitudinal_controller_node to use VehicleOdometry * Update lateral_controller_node for VehicleOdometry and SteeringReport * Fix tests Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * Change the topic name of the control_cmd to align them in trajectory_follower_node (autowarefoundation#659) * Fix topic names * Fix namespace * Fix test codes Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * Fix type of current odometry in trajectory_follower_node (autowarefoundation#666) Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * [latlon muxer] fix gtest (autowarefoundation#670) * fix gtest * remove unchanged Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * Update lateral controller (autowarefoundation#708) * Fix parameter names of mpc_follower (autowarefoundation#1376) * remove yaw_recalc param in mpc (autowarefoundation#1241) (autowarefoundation#1476) * parameterize curvature num (autowarefoundation#1674) (autowarefoundation#1577) * fix rosparam steer_rate_lim_degs to steer_rate_lim_dps in mpc_follower (autowarefoundation#1848) * Fix spellcheck fail for some packages autowarefoundation#1842 * use interpolation::slerp (autowarefoundation#2161) * Fix/mpc reset prev result (autowarefoundation#2185) * add add guard (autowarefoundation#2184) * add-mpc-optimization-status-print (autowarefoundation#2189) * Apply ament_uncrustify * Update control/trajectory_follower/src/qp_solver/qp_solver_osqp.cpp Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * Use vehicle info utils (autowarefoundation#709) * Use vehicle info utils and disable unit test * Update trajectory_follower_nodes default parameters and reenable tests * Separate vehicle info param file for test Co-authored-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * remove stop distance condition from stopState decision (autowarefoundation#1916) (autowarefoundation#715) Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * velocity_controller sync to .iv develop latest (autowarefoundation#699) * non extrapolate velocity in lerpTrajectory to avoid negative velocity just before vehicle stops (autowarefoundation#2033) * Add keep braking function at driving state (autowarefoundation#2346) * Add keep braking function at driving state Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Remove debug messages Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Fix format Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Feature/add doc for keep braking function at driving state (autowarefoundation#2366) * Add the description of brake keeping Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Add the english document Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Improve description Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * Add english description Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix topic name in plot juggler (autowarefoundation#734) Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * Fix unstable test in trajectory_follower_nodes (autowarefoundation#731) * Added spin_some to store tf_buffer * add more spin * uncomment statement * Remove temp file * Update control/trajectory_follower_nodes/src/lateral_controller_node.cpp Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Joshua Whitley <josh.whitley@autoware.org> Co-authored-by: Igor Bogoslavskyi <igor.bogoslavskyi@gmail.com> Co-authored-by: MIURA Yasuyuki <kokosabu@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>

…age (#666) * fix(autoware_state_panel): fix message type for /api/autoware/get/engage Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…/get/engage (#666)" This reverts commit 49cc906.

* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (#633)" This reverts commit 15f43bc.

…ion#1079) * Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)" This reverts commit 15f43bc. Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>

…ion#1079) * Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (autowarefoundation#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (autowarefoundation#633)" This reverts commit 15f43bc.

* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (#633)" This reverts commit 15f43bc.

…age (#666) * fix(autoware_state_panel): fix message type for /api/autoware/get/engage Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Revert "fix(autoware_state_panel): fix message type for /api/autoware/get/engage (#666)" This reverts commit 49cc906. * Revert "fix(tier4_state_rviz_plugin): change service and topic name for engage (#633)" This reverts commit 15f43bc.