Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules #6625

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Mar 15, 2024

Description

Add a general method to obtain the correct turnSignalInfo for all behavior path planner modules.
This PR implements only the method itself. The method has been tested with the start planner, goal planner, avoidance and lane change modules as depicted here: #6622
This PR is 1 of 5 and the other PRs will depend on this one (to be linked)

Please see the Above link for further details

After approving this PR, the following PRs implement this method in the bpp modules:

Avoidance: #6626
Lane Change: #6627
Start Planner: #6628
Goal Planner: #6629

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielsanchezaran danielsanchezaran added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 15, 2024
@danielsanchezaran danielsanchezaran enabled auto-merge (squash) March 15, 2024 12:06
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 14.83%. Comparing base (6ee9627) to head (48186cd).
Report is 8 commits behind head on main.

Files Patch % Lines
...or_path_planner_common/src/turn_signal_decider.cpp 0.00% 69 Missing ⚠️
...havior_path_planner_common/turn_signal_decider.hpp 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6625      +/-   ##
==========================================
+ Coverage   14.79%   14.83%   +0.04%     
==========================================
  Files        1920     1920              
  Lines      132398   134201    +1803     
  Branches    39345    40636    +1291     
==========================================
+ Hits        19582    19904     +322     
- Misses      90970    92193    +1223     
- Partials    21846    22104     +258     
Flag Coverage Δ *Carryforward flag
differential 10.70% <0.00%> (?)
total 14.79% <ø> (ø) Carriedforward from 6ee9627

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit 52b2fd6 into autowarefoundation:main Mar 15, 2024
37 of 39 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/add-general-calc-turn-signal-method branch March 15, 2024 13:42
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…g turn signal for bpp modules (autowarefoundation#6625)

add general method for calculating turn signal for bpp modules

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request May 24, 2024
…g turn signal for bpp modules (autowarefoundation#6625)

add general method for calculating turn signal for bpp modules

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…g turn signal for bpp modules (autowarefoundation#6625)

add general method for calculating turn signal for bpp modules

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
saka1-s added a commit to tier4/autoware.universe that referenced this pull request Jun 4, 2024
…g turn signal for bpp modules v0.19.1 (#1313)

* feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules (autowarefoundation#6625)

add general method for calculating turn signal for bpp modules

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(behavior_path_avoidance_module): use the general calc turn signal method (autowarefoundation#6626)

use the general calc turn signal method

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(lane_change_module): add general method to get turn signal for LC module (autowarefoundation#6627)

add general method to get turn signal for LC module

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(start_planner): add general turn signal method to start planner (autowarefoundation#6628)

* Add general turnSignal method to start planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add description to ignore signal

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(goal_planner): add general turnsignalinfo method for goal planner (autowarefoundation#6629)

add general turnsignalinfo method for goal planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* resolve merge conflict

* add turn_signal_remaining_shift_length_threshold

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* include utility header to use std::pair

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp>
Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…g turn signal for bpp modules (autowarefoundation#6625)

add general method for calculating turn signal for bpp modules

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants