Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emergency_handler): use operation mode availability for emergency handler #6352

Conversation

TetsuKawa
Copy link
Contributor

Description

This pull request replace hazard_status with operation_mode_availability and adds process to request pull over.

Related links

Tests performed

  • Tested that the handler requests pull over in case that value of operation_mode_availability -> autonomous is false and the value of operation_mode_availability -> pull_over is true.
  • Tested that mrm state transitions as per mrm-state.svg.

How to test

autoware.universe

tier4_autoware_msgs

Notes for reviewers

Is it ok to have a transition that pulls over after emergency_stop or comfortable_stop?

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Feb 7, 2024
@TetsuKawa
Copy link
Contributor Author

Instead of changing emergency_handler, create a new node called mrm_handler and replace it with emergency_handler.

@TetsuKawa TetsuKawa closed this Feb 28, 2024
@TetsuKawa TetsuKawa deleted the feat/use-operation-mode-availability-for-emergency-handler branch February 28, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants