Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_stop): add vector size guard #6254

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jan 31, 2024

Description

add vector size guard to fix this issue #6151

Tests performed

psim tests

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 31, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review January 31, 2024 10:14
@yuki-takagi-66 yuki-takagi-66 changed the title add guard fix(obstacle_stop): add vector size guard Jan 31, 2024
Copy link
Member

@brkay54 brkay54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (82d1b10) 14.40% compared to head (b08e745) 14.40%.
Report is 9 commits behind head on main.

Files Patch % Lines
planning/obstacle_stop_planner/src/node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6254      +/-   ##
==========================================
- Coverage   14.40%   14.40%   -0.01%     
==========================================
  Files        1906     1906              
  Lines      129850   129851       +1     
  Branches    37571    37572       +1     
==========================================
  Hits        18700    18700              
- Misses      90157    90158       +1     
  Partials    20993    20993              
Flag Coverage Δ *Carryforward flag
differential 8.84% <0.00%> (?)
total 14.40% <ø> (ø) Carriedforward from 82d1b10

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit 55c52af into autowarefoundation:main Feb 1, 2024
32 of 37 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/obstacle_stop-add-guard branch February 1, 2024 03:30
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Feb 1, 2024
* add guard

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* add guard

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants