Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lanelet2_map_loader): enrich error message #6245

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jan 31, 2024

Description

Improve the error message when the map load fails.

Tests performed

run psim and check the error message.

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Jan 31, 2024
@TakaHoribe TakaHoribe added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:map Map creation, storage, and loading. (auto-assigned) labels Jan 31, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request.
I think it is a good idea to make the log output more detailed.
Looks Good To Me

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (25bc636) 14.39% compared to head (57b8f19) 14.39%.
Report is 11 commits behind head on main.

Files Patch % Lines
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6245      +/-   ##
==========================================
- Coverage   14.39%   14.39%   -0.01%     
==========================================
  Files        1906     1906              
  Lines      129847   129852       +5     
  Branches    37572    37577       +5     
==========================================
  Hits        18697    18697              
- Misses      90155    90160       +5     
  Partials    20995    20995              
Flag Coverage Δ *Carryforward flag
differential 26.57% <0.00%> (?)
total 14.39% <ø> (ø) Carriedforward from 25bc636

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit f825ff0 into autowarefoundation:main Feb 2, 2024
34 of 37 checks passed
@SakodaShintaro SakodaShintaro deleted the enrich-error-msg-map-loader branch February 2, 2024 04:46
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…6245)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…6245)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants