Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix deviated path update #6221

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 30, 2024

Description

when ego vehicle is far from previous module output, do not update path based on that to prevent sudden steer maneuver

Tests performed

evaluator_description: fix/goal_planner_path_update
2024/01/30 https://evaluation.tier4.jp/evaluation/reports/a424adc8-7204-5a6f-ae4c-3a03318c8b86/?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 30, 2024
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4f7fded) 15.14% compared to head (f3d2bfa) 15.14%.
Report is 5 commits behind head on main.

Files Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6221      +/-   ##
==========================================
- Coverage   15.14%   15.14%   -0.01%     
==========================================
  Files        1789     1789              
  Lines      123277   123284       +7     
  Branches    37471    37471              
==========================================
  Hits        18673    18673              
- Misses      83630    83637       +7     
  Partials    20974    20974              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.14% <ø> (ø) Carriedforward from 4f7fded

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit 5e8da39 into autowarefoundation:main Jan 30, 2024
33 of 37 checks passed
@kosuke55 kosuke55 deleted the fix/goal_planner_path_update branch January 30, 2024 09:48
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants